Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aliases for options of final_internal_class fixer #4922

Closed
a-menshchikov opened this issue Apr 15, 2020 · 3 comments
Closed

Add aliases for options of final_internal_class fixer #4922

a-menshchikov opened this issue Apr 15, 2020 · 3 comments

Comments

@a-menshchikov
Copy link

Now options contain dashes what prevents to use this fixer in EasyCodingStandard (which replaces dashes with underscores).
To resolve this problem options of final_internal_class should be aliased with values, where dashes will be replaced with underscores.

@SpacePossum
Copy link
Contributor

👍
we should also update the auto review tests to no longer allow dashes in the names of options (and possible other characters as well)

@kubawerlos
Copy link
Contributor

@a-menshchikov this will be solved with the release of 2.17, it's already merged: #4634

@julienfalque
Copy link
Member

Indeed, totally forgot about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants