Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PhpdocTypesFixer - fix recognizing callable #6322

Closed
wants to merge 2 commits into from
Closed

PhpdocTypesFixer - fix recognizing callable #6322

wants to merge 2 commits into from

Conversation

kubawerlos
Copy link
Contributor

No description provided.

@kubawerlos kubawerlos marked this pull request as ready for review March 2, 2022 18:16
@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 93.199% when pulling ccb953e on werlos:fix_PhpdocTypesFixer_case_sensitivity into f45c5a0 on FriendsOfPHP:master.

@SpacePossum
Copy link
Contributor

  The command "git push origin "master" refs/notes/github-comments" failed.                       
                                                                                                  
  Exit Code: 1(General error)                                                                     
                                                                                                  
  Working directory: /home/possum/work/master/PHP-CS-Fixer                                        
                                                                                                  
  Output:                                                                                         
  ================                                                                                
                                                                                                  
                                                                                                  
  Error Output:                                                                                   
  ================                                                                                
  remote: error: GH006: Protected branch update failed for refs/heads/master.                     
  remote: error: At least 1 approving review is required by reviewers with write access.          
  To github.com:FriendsOfPHP/PHP-CS-Fixer.git                                                     
     db0eb49f9..138157281  refs/notes/github-comments -> refs/notes/github-comments               
   ! [remote rejected]     master -> master (protected branch hook declined)                      
  error: failed to push some refs to 'git@github.com:FriendsOfPHP/PHP-CS-Fixer.git'               
                                                                                        

@keradus I can no longer merge because of the new rules, so someone else has to take over

@keradus
Copy link
Member

keradus commented Mar 7, 2022

can you try again, @SpacePossum ?

yet another strong point to finalise getting out of gh tool, imho

@SpacePossum
Copy link
Contributor

Thank you @kubawerlos.

@SpacePossum
Copy link
Contributor

and thanks @keradus , merge went all fine now 👍

@kubawerlos kubawerlos deleted the fix_PhpdocTypesFixer_case_sensitivity branch March 7, 2022 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants