New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minor: Let PhpdocLineSpan fixer detect docblocks when seperator from token with attribute #6343
minor: Let PhpdocLineSpan fixer detect docblocks when seperator from token with attribute #6343
Conversation
Thanks for the PR! and sorry for the long wait. I left a little minor, but with or without it applied I think this PR RTM |
thanks for the changes @bobvandevijver 👍 @julienfalque can you allow the workflow to run? thanks! |
Maybe a rebase would help to fix the static analysis? |
It should be fixed by #6506. |
c23eae3
to
1f82554
Compare
Looks like phpstan is finding 13 errors, but they are all in other files... |
yeah I think what it really wants is some type docs on the newly created dataprovider, but not 100% sure, maybe Julien has an idea on this one :) thanks for change from |
Yep, I think the reported error is the last that matches the ignore regexp, not necessarily the one that is added by your changes. |
52e4cab
to
a4dbc64
Compare
@julienfalque I actually had |
I think |
Thank you @bobvandevijver. |
thanks @bobvandevijver , nice one :) |
This fix allows the phpdoc_line_span fixer to detect attributes between a docblock and the token it is working on.
It now updates (depending on the configuration)
to
while it did not touch this structure before.