minor: ReturnAssignmentFixer - Support for anonymous classes, lambda and match

[SpacePossum]

No description provided.

[coveralls]

Coverage increased (+0.01%) to 92.926% when pulling 4aa3d86 on SpacePossum:master_ReturnAssignmentFixer_support_more_cases into 22804e8 on FriendsOfPHP:master.

[GrahamCampbell]

Note for other reviewers. Changes since the last version, in the force push:

With that in mind, are we missing a test case, here?

[SpacePossum]

Thanks for providing the details about the change!

The first change is an internal PHPDoc change for the method, I noticed that I had copy-pasted the doc and as such decided to make it a bit more accurate.

The second change is adding !$tokens->isTokenKindsFound to the function.
The functions job is to figure out if we are detailing with an enum. The added check is a cheap negative test; it checks if when the PHP code was tokenized it did contain any enum. If it didn't we can skip all the detection logic for an enum as it will never be in the collection.
This, to me, seems a nice optimization, yet not required from a pure functional perspective which is why I didn't adjust a utest for it.

[GrahamCampbell]

Ah, perfect. 👌

[SpacePossum]

rebased, no other changes

[SpacePossum]

rebased without changes, than added a new commit

[SpacePossum]

This PR is now a bug fix as well, as it fixes the previous fixed issue with references returned but this time for nested functions as well.

[SpacePossum]

rebased on latest without any other changes

[julienfalque]

Thank you @SpacePossum.