minor: ExplicitStringVariableFixer - Fix to PHP8.2 compat code

[SpacePossum]

PHP8.2

see: #3488 (comment)

ping @dmvdbrugge as author of the rule, ping @iluuu1994 as author of the PHP language change, please have a look and let me know what you guys think, thanks! 👍

Stricktly this change could be considered a BC break, but fixing towards a PHP8.2 deprecated code style is more problematic and outweighs the minor BC thing IMHO.

[coveralls]

Coverage remained the same at 92.873% when pulling 0ee2b9d on SpacePossum:master_php82_ExplicitStringVariableFixer into 7936fb2 on FriendsOfPHP:master.

[dmvdbrugge]

If I look at the linked comment, @Slamdunk is the author of ExplicitStringVariableFixer, I'm merely the author of SimpleToComplexVariableFixer (which should now be included in any "migrate to php 8.2+" sets).

It is correct the priority is no longer needed as the former will no longer produce the result the latter is fixing.

Anyway, the change looks good. Is this targeting a minor or a patch release? I wouldn't do patch because of the BC thing, but if you specify this as "8.2 compatibility feature" then minor sounds good to me 😄

[SpacePossum]

Thanks for your thoughts @dmvdbrugge , much appreciated :) we'll have to see when and how this gets shipped, but good points 👍

[iluuu1994]

LGTM. This doesn't handle the deprecated var var syntax "${expr}" described in the RFC but to be fair I couldn't find a single case of those in the wild with my script.

[SpacePossum]

Thanks @iluuu1994 :)
We have an additional rule to rewrite those cases here:
simple_to_complex_string_variable
(additional tests cases).
Thanks for making the change in PHP and for checking things out here, much appreciated 👍

[iluuu1994]

Note that "${var}" is equivalent to "{$var}" (which is handled by simple_to_complex_string_variable), but "${expr}" is equivalent to "{${expr}}". The distinction is very confusing (hence the deprecation). But this is probably negligible as I doubt anybody actually used that syntax non-accidentally.