Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add intersection type to types_spaces rule description #6479

Merged
merged 1 commit into from Aug 1, 2022

Conversation

LevFlavien
Copy link
Contributor

Not sure if this is intended, but the type_spaces rule also affects intersection types.

Updated the documentation according to the current behavior.

@LevFlavien LevFlavien changed the title doc: Update types_spaces description docs: Update types_spaces description Jul 13, 2022
@LevFlavien LevFlavien changed the title docs: Update types_spaces description docs: Add intersection type to types_spaces rule description Jul 13, 2022
@SpacePossum
Copy link
Contributor

SpacePossum commented Jul 20, 2022

Hi and thanks for making this PR.

The behavior is intended so your doc change looks good.

Please update the description of the fixer in it own file, like in this file but on your local setup:
https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/v3.9.4/src/Fixer/Whitespace/TypesSpacesFixer.php#L49

Than you can run from the CLI in the root of the project:

php dev-tools/doc.php

This should give you all the changes need for the tests to pass, good luck 👍

@LevFlavien
Copy link
Contributor Author

Hi @SpacePossum

Thank you, PR updated.

@SpacePossum
Copy link
Contributor

thanks, looking good! 👍

RTM from me if the tests pass, please approve the workflows @ maintainers :)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.913% when pulling 6162430 on LevFlavien:patch-1 into 22804e8 on FriendsOfPHP:master.

@julienfalque julienfalque merged commit 979454b into PHP-CS-Fixer:master Aug 1, 2022
@julienfalque
Copy link
Member

Thank you @LevFlavien.

@LevFlavien LevFlavien deleted the patch-1 branch August 4, 2022 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants