bug: Fix various indentation issues #6480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienfalque
force-pushed
the
fix-indentation
branch
2 times, most recently
from
87f81ac
to
c8659fe
Compare
julienfalque
commented
Jul 14, 2022
| yield 'with several opening braces on same line' => [ | ||
| '<?php | ||
| if ($foo) { if ($foo) { foo(); | ||
| if ($bar) { if ($bar) { bar(); } | ||
| baz(); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Fixing the tests with anonymous functions added below without breaking this one is super tricky and I could not find a solution yet. Since this is a very odd edge case—unlike the ones being fixed—I think this is an acceptable trade-off.
kubawerlos
approved these changes
Jul 14, 2022
julienfalque
force-pushed
the
fix-indentation
branch
from
c8659fe
to
50b3550
Compare
|
kudos! |
kayw-geek
pushed a commit
to kayw-geek/PHP-CS-Fixer
that referenced
this pull request
Jul 16, 2022
Fix various indentation issues
kayw-geek
pushed a commit
to kayw-geek/PHP-CS-Fixer
that referenced
this pull request
Jul 16, 2022
Fix various indentation issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6478, the remaining case from #6471 (comment) and some cases from #6470.