Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DX: Remove redundant check for PHP <5.2.7 #6620

Merged
merged 2 commits into from Sep 18, 2022
Merged

DX: Remove redundant check for PHP <5.2.7 #6620

merged 2 commits into from Sep 18, 2022

Conversation

jrmajor
Copy link
Contributor

@jrmajor jrmajor commented Sep 4, 2022

We get a parse error on PHP <7.0 anyway: https://3v4l.org/67j6J#v5.2.6.

Also, maybe the check for HHVM can be dropped too?

@coveralls
Copy link

coveralls commented Sep 4, 2022 •
edited

Coverage Status

Coverage remained the same at 92.915% when pulling cb55c6f on jrmajor:dx/52-check into aafad72 on FriendsOfPHP:master.

@julienfalque
Copy link
Member

Also, maybe the check for HHVM can be dropped too?

IMO yes.

@jrmajor
Copy link
Contributor Author

jrmajor commented Sep 4, 2022

@julienfalque Done.

@julienfalque julienfalque merged commit 39671cb into PHP-CS-Fixer:master Sep 18, 2022
@julienfalque
Copy link
Member

Thank you @jrmajor.

@jrmajor jrmajor deleted the dx/52-check branch September 18, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienfalque julienfalque julienfalque approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jrmajor @coveralls @julienfalque