Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Allow installation of sebastian/diff:^5.0.0 #6771

Merged
merged 1 commit into from
Feb 4, 2023

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Feb 3, 2023

This pull request

  • allows installation of sebastian/diff:^5.0.0

πŸ’β€β™‚οΈ phpunit/phpunit:10.0.0 requires sebastian/diff:^5.0.0, so currently phpunit/phpunit:^10.0.0 and friendsofphp/php-cs-fixer:^3.14.3 conflict.

For reference, see sebastianbergmann/diff@4.0.0...5.0.0.

@localheinz localheinz changed the title Enhancement: Allow installation of sebastian/diff:^5.0.0 feature: Allow installation of sebastian/diff:^5.0.0 Feb 3, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4085228441

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.95%

Totals Coverage Status
Change from base Build 4048086535: 0.0%
Covered Lines: 22702
Relevant Lines: 24424

πŸ’› - Coveralls

@localheinz localheinz self-assigned this Feb 4, 2023
@localheinz localheinz marked this pull request as draft February 4, 2023 12:24
@keradus
Copy link
Member

keradus commented Feb 4, 2023

I am not sure why differ is dropping support for v8.0 :(

overall, if green, happy to merge. not sure why marked as draft, anything more you plan in here, @localheinz ?

@negoziator
Copy link

Yes, please - this holds back updates to phpunit/phpunit:^10.0.0 for so many people πŸ˜„

@negoziator
Copy link

@keradus @localheinz

The draft thing. Isn't that just a mistake? πŸ˜„

I can't come up with any other needs for this to be merged.

@localheinz localheinz marked this pull request as ready for review February 4, 2023 22:03
@localheinz
Copy link
Member Author

@keradus @negoziator

I'm not sure if we need to change anything else here - what do you think?

@negoziator
Copy link

@localheinz @keradus .

I don't think so - imo, this should just be shipped.

and thank you btw πŸ˜„

@keradus
Copy link
Member

keradus commented Feb 4, 2023

I trust the CI, we put a lot there to cover deps updates compact issues, if any.

thanks, @localheinz !

@keradus keradus merged commit fa326d3 into PHP-CS-Fixer:master Feb 4, 2023
@localheinz localheinz deleted the feature/diff branch February 4, 2023 22:07
@localheinz
Copy link
Member Author

Thank you, @keradus and @negoziator!

@negoziator
Copy link

@keradus - are you making a 3.14.4 release ?

@sakarikl
Copy link

sakarikl commented Feb 7, 2023

When is 3.14.4 planned to be released?

@LeTraceurSnork
Copy link

@keradus
just to make a crowd - please create a 3.14.4 :-)

@keradus
Copy link
Member

keradus commented Feb 9, 2023

released as 3.14.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants