-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install documentation misses recommended "tools/php-cs-fixer" dir method #8020
Comments
The recommended way is mentioned in the readme and the example of how to do it is shown right below. Then you have:
The separate page lists alternative installation methods, so from the readme (and main docs) point of view it's correct. But if you land directly on installation instructions it in fact misses the recommended installation, so probably we should add it there too. Do you want to update the installation docs? |
No, I don't want to update the installation docs. |
Can I suggest that we add some rationale to this recommendation in the docs. Im new to this project and opted to not go with the recommendation as there no clear reason or guidance as to why I should be. |
@JParkinson1991 the rationale behind it is that your dev tools should not affect your production dependencies. Yes, you can add it to |
This also works the other way around by the way: production dependencies should not affect dev tools. Every two years, we receive requests to make PHP CS Fixer compatible with the new major version of Symfony. This creates an unnecessary burden on us. We should be free to upgrade Symfony components we depend on whenever we feel the need to, not when one wants to update their app. |
Problem description
The README states:
But the separate installation documentation does not say anything about that: https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/blob/master/doc/installation.rst
The "recommended way" was added to the README in 1d01692.
Minimal reproducer
Compare https://github.com/PHP-CS-Fixer/PHP-CS-Fixer?tab=readme-ov-file#installation with https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/blob/master/doc/installation.rst
Fixer version
v3.57.1
PHP version
8.2
How do you run Fixer?
Composer package
Contribution Checks
The text was updated successfully, but these errors were encountered: