Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8 - Method ReflectionParameter::getClass() is deprecated #19

Closed
kocsismate opened this issue Aug 7, 2020 · 3 comments · Fixed by #20
Closed

PHP 8 - Method ReflectionParameter::getClass() is deprecated #19

kocsismate opened this issue Aug 7, 2020 · 3 comments · Fixed by #20
Labels

Comments

@kocsismate
Copy link
Contributor

kocsismate commented Aug 7, 2020

Hi Matthieu,

PHP 8 deprecates the ReflectionParameter::getClass() method, and suggests the usage of ReflectionParameter::getType(). This causes problems (and a slight performance penalty) to PHP-DI.

@mnapoli
Copy link
Member

mnapoli commented Aug 8, 2020

There are some commits in PHP-DI/PHP-DI#726 that solve this in PHP-DI, we should apply the same logic here (if anyone is up for a PR).

@mnapoli mnapoli added the bug label Aug 8, 2020
@mnapoli mnapoli changed the title Method ReflectionParameter::getClass() is deprecated PHP 8 - Method ReflectionParameter::getClass() is deprecated Sep 28, 2020
@mnapoli
Copy link
Member

mnapoli commented Sep 28, 2020

I started working on #20 but PHP 8 support is harder than I anticipated.

@kocsismate
Copy link
Contributor Author

Thank you @mnapoli for the fix! I didn't get around implementing this, because I was too busy with PHP 8 before the RCs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants