Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TimeCode From Seconds Is Incorrect #734

Open
benbankes opened this issue Jun 17, 2020 · 0 comments · May be fixed by #735
Open

TimeCode From Seconds Is Incorrect #734

benbankes opened this issue Jun 17, 2020 · 0 comments · May be fixed by #735

Comments

@benbankes
Copy link

benbankes commented Jun 17, 2020 •
edited

Q A
Bug? yes
New Feature? no
Version Used v0.16
FFmpeg Version ffmpeg version 3.4.6-0ubuntu0.18.04.1 Copyright (c) 2000-2019 the FFmpeg developers built with gcc 7 (Ubuntu 7.3.0-16ubuntu3)
OS Ubuntu 18.04

Actual Behavior

TimeCode::fromSeconds(59.99999); // 00:00:59.100

Expected Behavior

TimeCode::fromSeconds(59.99999); // 00:01:00.00 (not 00:00:59.999)

Steps to Reproduce

$seconds = 59.99999;
TimeCode::fromSeconds($seconds);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Carry over any full seconds due to rounding within TimeCode::fromSeconds benbankes/PHP-FFMpeg
1 participant
@benbankes