-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Internal: GHA "Fix Code Style" fails #142
Comments
Am I correct that this is caused by the branch protection of main? Wouldn't it be better to do the code style fixing directly on the pull request? |
Yes! I'm pretty sure I advocated for it but no idea what/when it happened anymore 😅 It would be possible to do on master with a token with appropriate permission. Not sure if on PRs there can be other issues like PR creators not allowing push etc., would need to test this. PS: unassigning me, seems I'm optimistic in doing stuff but not finding time currently. |
Yes, we can add this on workflow on PR closed/merged or when it opens since we don't need to wait until it goes to the main. If I not wrong, there's are phpcs or something like that in the official PHP actions repository. |
@Messhias do you have time to check this out and change it? |
I don't have time right now since I'm doing the same configurations in my current company for our PHP project. But I'll share my php.yml that's in the workflow where I believe that we can insert into this repository workflow:
Of course,e it's not the whole file, I'm mentioning this specific line:
|
I propose we simply don't run it on main, arguments are laid out in #234 |
fixed with #234 , yay 🎉 |
Subject of the issue
After #141 was merged, on master https://github.com/PHP-Open-Source-Saver/jwt-auth/runs/6501560509?check_suite_focus=true was triggered and failed:
The text was updated successfully, but these errors were encountered: