-
-
Notifications
You must be signed in to change notification settings - Fork 190
/
BaseSniffTest.php
349 lines (305 loc) · 10.8 KB
/
BaseSniffTest.php
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
<?php
/**
* Base sniff test class file.
*
* @package PHPCompatibility
*/
namespace PHPCompatibility\Tests;
use PHPCompatibility\PHPCSHelper;
/**
* BaseSniffTest
*
* Adds PHPCS sniffing logic and custom assertions for PHPCS errors and
* warnings.
*
* @uses \PHPUnit_Framework_TestCase
* @package PHPCompatibility
* @author Jansen Price <jansen.price@gmail.com>
*/
class BaseSniffTest extends \PHPUnit_Framework_TestCase
{
const STANDARD_NAME = 'PHPCompatibility';
/**
* The PHP_CodeSniffer object used for testing.
*
* Used by PHPCS 1.x and 2.x.
*
* @var PHP_CodeSniffer
*/
protected static $phpcs = null;
/**
* An array of PHPCS results by filename and PHP version.
*
* @var array
*/
public static $sniffFiles = array();
/**
* Sets up this unit test.
*
* @return void
*/
public static function setUpBeforeClass()
{
self::$sniffFiles = array();
parent::setUpBeforeClass();
}
/**
* Sets up this unit test.
*
* @return void
*/
protected function setUp()
{
if (class_exists('\PHP_CodeSniffer') === true) {
/*
* PHPCS 1.x and 2.x.
*/
if (self::$phpcs === null) {
self::$phpcs = new \PHP_CodeSniffer();
}
if (method_exists('\PHP_CodeSniffer_CLI', 'setCommandLineValues')) {
// For PHPCS 2.x.
self::$phpcs->cli->setCommandLineValues(array('-pq', '--colors'));
}
// Restrict the sniffing of the test case files to the particular sniff being tested.
if (method_exists('\PHP_CodeSniffer', 'initStandard')) {
self::$phpcs->initStandard(self::STANDARD_NAME, array($this->getSniffCode()));
} else {
// PHPCS 1.x.
self::$phpcs->process(array(), dirname(__DIR__) . '/', array($this->getSniffCode()));
}
self::$phpcs->setIgnorePatterns(array());
}
parent::setUp();
}
/**
* Tear down after each test.
*
* @return void
*/
public function tearDown()
{
// Reset the targetPhpVersion.
PHPCSHelper::setConfigData('testVersion', null, true);
}
/**
* Tear down after each test.
*
* @return void
*/
public static function tearDownAfterClass()
{
self::$sniffFiles = array();
}
/**
* Get the sniff code for the current sniff being tested.
*
* @return string
*/
protected function getSniffCode()
{
$class = get_class($this);
$parts = explode('\\', $class);
$sniff = array_pop($parts);
$sniff = str_replace('SniffTest', '', $sniff);
$category = array_pop($parts);
return self::STANDARD_NAME . '.' . $category . '.' . $sniff;
}
/**
* Sniff a file and return resulting file object.
*
* @param string $filename Filename to sniff.
* @param string $targetPhpVersion Value of 'testVersion' to set on PHPCS object.
*
* @return \PHP_CodeSniffer_File|false File object.
*/
public function sniffFile($filename, $targetPhpVersion = 'none')
{
if (isset(self::$sniffFiles[$filename][$targetPhpVersion])) {
return self::$sniffFiles[$filename][$targetPhpVersion];
}
if ('none' !== $targetPhpVersion) {
PHPCSHelper::setConfigData('testVersion', $targetPhpVersion, true);
}
$pathToFile = realpath(__DIR__) . DIRECTORY_SEPARATOR . $filename;
try {
if (class_exists('\PHP_CodeSniffer\Files\LocalFile')) {
// PHPCS 3.x.
$config = new \PHP_CodeSniffer\Config();
$config->cache = false;
$config->standards = array(self::STANDARD_NAME);
$config->sniffs = array($this->getSniffCode());
$config->ignored = array();
$ruleset = new \PHP_CodeSniffer\Ruleset($config);
self::$sniffFiles[$filename][$targetPhpVersion] = new \PHP_CodeSniffer\Files\LocalFile($pathToFile, $ruleset, $config);
self::$sniffFiles[$filename][$targetPhpVersion]->process();
} elseif (method_exists('\PHP_CodeSniffer', 'initStandard')) {
// PHPCS 2.x.
self::$sniffFiles[$filename][$targetPhpVersion] = self::$phpcs->processFile($pathToFile);
} else {
// PHPCS 1.x - Sniff code restrictions have to be passed via the function call.
self::$sniffFiles[$filename][$targetPhpVersion] = self::$phpcs->processFile($pathToFile, null, array($this->getSniffCode()));
}
} catch (\Exception $e) {
$this->fail('An unexpected exception has been caught: ' . $e->getMessage());
return false;
}
return self::$sniffFiles[$filename][$targetPhpVersion];
}
/**
* Assert a PHPCS error on a particular line number.
*
* @param \PHP_CodeSniffer_File $file Codesniffer file object.
* @param int $lineNumber Line number.
* @param string $expectedMessage Expected error message (assertContains).
*
* @return bool
*/
public function assertError(\PHP_CodeSniffer_File $file, $lineNumber, $expectedMessage)
{
$errors = $this->gatherErrors($file);
return $this->assertForType($errors, 'error', $lineNumber, $expectedMessage);
}
/**
* Assert a PHPCS warning on a particular line number.
*
* @param \PHP_CodeSniffer_File $file Codesniffer file object.
* @param int $lineNumber Line number.
* @param string $expectedMessage Expected message (assertContains).
*
* @return bool
*/
public function assertWarning(\PHP_CodeSniffer_File $file, $lineNumber, $expectedMessage)
{
$warnings = $this->gatherWarnings($file);
return $this->assertForType($warnings, 'warning', $lineNumber, $expectedMessage);
}
/**
* Assert a PHPCS error or warning on a particular line number.
*
* @param array $issues Array of issues of a particular type.
* @param string $type The type of issues, either 'error' or 'warning'.
* @param int $lineNumber Line number.
* @param string $expectedMessage Expected message (assertContains).
*
* @return bool
*/
private function assertForType($issues, $type, $lineNumber, $expectedMessage)
{
if (isset($issues[$lineNumber]) === false) {
throw new \Exception("Expected $type '$expectedMessage' on line number $lineNumber, but none found.");
}
$insteadFoundMessages = array();
// Concat any error messages so we can do an assertContains.
foreach ($issues[$lineNumber] as $issue) {
$insteadFoundMessages[] = $issue['message'];
}
$insteadMessagesString = implode(', ', $insteadFoundMessages);
return $this->assertContains(
$expectedMessage,
$insteadMessagesString,
"Expected $type message '$expectedMessage' on line $lineNumber not found. Instead found: $insteadMessagesString."
);
}
/**
* Assert no violation (warning or error) on a given line number.
*
* @param \PHP_CodeSniffer_File $file Codesniffer File object.
* @param mixed $lineNumber Line number.
*
* @return bool
*/
public function assertNoViolation(\PHP_CodeSniffer_File $file, $lineNumber = 0)
{
$errors = $this->gatherErrors($file);
$warnings = $this->gatherWarnings($file);
if (empty($errors) && empty($warnings)) {
return $this->assertTrue(true);
}
if ($lineNumber === 0) {
$failMessage = 'Failed asserting no violations in file. Found ' . count($errors) . ' errors and ' . count($warnings) . ' warnings.';
$allMessages = $errors + $warnings;
// TODO: Update the fail message to give the tester some
// indication of what the errors or warnings were.
return $this->assertEmpty($allMessages, $failMessage);
}
$encounteredMessages = array();
if (isset($errors[$lineNumber])) {
foreach ($errors[$lineNumber] as $error) {
$encounteredMessages[] = 'ERROR: ' . $error['message'];
}
}
if (isset($warnings[$lineNumber])) {
foreach ($warnings[$lineNumber] as $warning) {
$encounteredMessages[] = 'WARNING: ' . $warning['message'];
}
}
$failMessage = "Failed asserting no standards violation on line $lineNumber. Found: \n"
. implode("\n", $encounteredMessages);
$this->assertCount(0, $encounteredMessages, $failMessage);
}
/**
* Show violations in file by line number.
*
* This is useful for debugging sniffs on a file.
*
* @param \PHP_CodeSniffer_File $file Codesniffer file object.
*
* @return array
*/
public function showViolations(\PHP_CodeSniffer_File $file)
{
$violations = array(
'errors' => $this->gatherErrors($file),
'warnings' => $this->gatherWarnings($file),
);
return $violations;
}
/**
* Gather all error messages by line number from phpcs file result.
*
* @param \PHP_CodeSniffer_File $file Codesniffer File object.
*
* @return array
*/
public function gatherErrors(\PHP_CodeSniffer_File $file)
{
$foundErrors = $file->getErrors();
return $this->gatherIssues($foundErrors);
}
/**
* Gather all warning messages by line number from phpcs file result.
*
* @param \PHP_CodeSniffer_File $file Codesniffer File object.
*
* @return array
*/
public function gatherWarnings(\PHP_CodeSniffer_File $file)
{
$foundWarnings = $file->getWarnings();
return $this->gatherIssues($foundWarnings);
}
/**
* Gather all messages or a particular type by line number.
*
* @param array $issuesArray Array of a particular type of issues,
* i.e. errors or warnings.
*
* @return array
*/
private function gatherIssues($issuesArray)
{
$allIssues = array();
foreach ($issuesArray as $line => $lineIssues) {
foreach ($lineIssues as $column => $issues) {
foreach ($issues as $issue) {
if (isset($allIssues[$line]) === false) {
$allIssues[$line] = array();
}
$allIssues[$line][] = $issue;
}
}
}
return $allIssues;
}
}