New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please use annotated or signed tags for releases #752
Comments
This is really a GitHub problem - all the release tags since 5.2.9 have been made with GitHub's release creation system - I can never remember git syntax and always seem to make a mess (if you look carefully you'll find tags with 4 or 5 attempts to set them correctly), so I simply avoid it. |
Composer doesn't have an issue with this - is there any reason you're using submodules rather than composer? |
I didn't realize that you were creating the tags via the Github releases interface. I guess that explains why they sometimes get rewritten... I wrote to Github support to request that they consider use of annotated/signed tags with their releases system, we'll see what they say. With regards to the syntax, it's not hard, really...
I'm not sure how composer deals with this, but the problem with submodules is the fact they use As to why we're using submodules and not composer, that's a legacy issue. We might make the switch at some point, but for now there are other priorities. |
I contacted Github support about this:
Here is the feedback I got
|
Hi! Take care, ljlorente |
Greetings,
Would it be possible for you guys to consistently tag releases (at least future ones), using either annotated (
git tag -a
) or signed (git tag -s
) tags ?I'm using PHPMailer as a git submodule. When checking submodule status, git relies on git describe to retrieve the version number, which by default only shows annotated tags. This results in incorrectly reporting the PHPmailer version as 5.2.9, which is the most recent signed tag:
Use of annotated vs lightweight tags seems to be a somewhat random act at the moment, as shown in the table below (data was extracted with
git tag | xargs -I% -n1 bash -c 'echo -n "% | "; git cat-file -t %'
):where type is either
tag
= signed or annotated, orcommit
= lightweight tagThanks in advance !
The text was updated successfully, but these errors were encountered: