Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Hyperlink text color for PowerPoint2007 writer #682

Merged
merged 6 commits into from Nov 25, 2021
Merged

Fix: Hyperlink text color for PowerPoint2007 writer #682

merged 6 commits into from Nov 25, 2021

Conversation

MartynasJanu
Copy link
Contributor

@MartynasJanu MartynasJanu commented Oct 28, 2021 •
edited

Hyperlinks can now be set to use the text color instead of the default theme color. This way it becomes possible to actually set the hyperlink color when using PowerPoint2007 writer.

Fixes #541

$textRun->getHyperlink()->setUrl($url);
$textRun->getHyperlink()->setUseTextColor(true);

@auto-assign auto-assign bot requested a review from Progi1984 October 28, 2021 13:46
@Progi1984
Copy link
Member

Progi1984 commented Nov 25, 2021 •
edited

@MartynasJanu Hi, Thank you for your contribution.

@Progi1984 Progi1984 added this to the 1.1.0 milestone Nov 25, 2021
@Progi1984 Progi1984 merged commit 47046dd into PHPOffice:develop Nov 25, 2021
@Progi1984 Progi1984 mentioned this pull request Nov 25, 2021
Closed
@nayanshah1921
Copy link

f9b55fb

This changes are not visible on develop or master branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Progi1984 Progi1984 Awaiting requested review from Progi1984

Assignees

@Progi1984 Progi1984

Labels
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

Hyperlink text color in PowerPoint2007
3 participants
@MartynasJanu @Progi1984 @nayanshah1921