Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anywhere position image #22

Closed
brunocasado opened this issue Jun 12, 2013 · 15 comments
Closed

Anywhere position image #22

brunocasado opened this issue Jun 12, 2013 · 15 comments
Milestone

Comments

@brunocasado
Copy link
Contributor

We need new feature for text/image wrapping. Today is very difficult align images.

maybe I can fork this project and contribute to it.

someone already did it?

@gabrielbull
Copy link
Member

Image wrapping is now done. See read me for example.

@Progi1984
Copy link
Member

@brunocasado Could you test and come back on this implementation ?

@brunocasado
Copy link
Contributor Author

Yes
soon as I can, i do it.

@Progi1984
Copy link
Member

Hi @brunocasado, i come back to you. Had you got some time for tests ?

@Progi1984
Copy link
Member

Note for me : When this implementation will be validated by @brunocasado, we will release PHPWord 0.7.0.

@jdespatis
Copy link

Any news on this feature @brunocasado ?
Thanks for this one ;)

@brunocasado
Copy link
Contributor Author

Guys,

Really sorry but i not had any time in this last month.

In this weekend i'll validate this implementation. I promise :)

@jdespatis
Copy link

Thanks @brunocasado !
I'm now even more happy to reach soon the end of this week so ;)

@Progi1984
Copy link
Member

Thanks @brunocasado. I wait for you :)

@jdespatis
Copy link

@brunocasado Have you been able to do some tests on this feature?
Thanks

@brunocasado
Copy link
Contributor Author

Yes i did,

I created a file test and i i'll do a pull request

wrappingStyle

inline : pass
Behind: pass
Infront: pass
Square: fail
Tight: fail

Square and Tight is displaying like infront.

An error is displayed: Fatal error: Call to undefined method PHPWord_Writer_ODText_Content::_writeSection() in /vagrant/PHPWord/Classes/PHPWord/Writer/ODText/Content.php on line 283

@Progi1984
Copy link
Member

As i can see in the commit fa77c4f, @gavroche has just pushed modifications for Word2007 support.

@Progi1984
Copy link
Member

@brunocasado Is it a problem if we correct this bug (for ODText) in the next release ?

@gabrielbull
Copy link
Member

@Progi1984 Can't you just close this one and open a new issue so we can go ahead with releases?

@jdespatis
Copy link

+1 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants