Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.8.2 - Support Registration with Phone number but not with invite only sites. #3016

Closed
PhpFoxJohnJr opened this issue May 20, 2021 · 7 comments

Comments

@PhpFoxJohnJr
Copy link

Important

Please follow this template!


What's happened?

PhpFox indicates the ability to register with a phone number.

Steps to reproduce:

  1. Turn on invite-only in adminCP

What's expected?

...The invite-only field should be coded the same way the registration field as either email or phone number. The invite send field should also accept either option as well. Come on guys, 3.6 - 4 billion smart phones in use today and mobile web traffic accounts for 52.6 percent of global traffic...

Browsers and Devices tested

(Example: Chrome on iPhone X, Safari on Macbook, Microsoft Edge on Windows 10, Firefox on Ubuntu 16.04, ...)

...

Server information

(Example: CentOS 7, php 7.1 apache)

...

phpFox version

(Example: phpFox 4.6.0)

...

Screenshots

...

@harrison05
Copy link
Contributor

Hi @PhpFoxJohnJr

Do you want us to allow send invitations via Phone number? See my screenshot

Screen Shot 2021-05-24 at 09 25 33

Regards.

@PhpFoxJohnJr
Copy link
Author

PhpFoxJohnJr commented May 24, 2021

Yes, It should use the same phone field and full_phone_number field in the User table. I tried the registration for the first time (honestly did try it before because I received no answer on the forum on how it worked) and it worked pretty damn well. I know now, you are able to go into your account settings now and add your email and can log in either way which is awesome!

The scenario I see is two people meet somewhere away from a computer and one person can send an invite to that person's phone and that person can accept it right there on their phone. This gives the opportunity for the invitee to explain some of the features and what to do without going back to either a pc because some people don't have their email set up on their phone or even like using email like my kids...who only text everything and never check their email.

I think the verification was also sent through the phone which was also a good idea as well.

The one thing I add for emails because I wanted to reduce the temptation to spam it but adding a limit. I added to the file:
PF.Base/module/invite/include/component/controller/index.class.php on line 26.

Add one more than you want. so 11 will let 10 emails go through (I didn't notify the users so the spammers will think it went through because no one should be sending that many invites for my site at once.

$aMails = explode(',', $aVals['emails'], 11);

I don't know if this is even possible with phone numbers.

Thanks for all you do!

@harrison05
Copy link
Contributor

We will check and improve this. It might available in the next version of phpFox.

Thanks for your request.

@harrison05 harrison05 added this to the 4.8.6 milestone May 26, 2021
@PhpFoxJohnJr
Copy link
Author

That would be very unexpected. I appreciate all the work you guys and girls do, and I try to help out when I can :)

@harrison05
Copy link
Contributor

We improved this feature in phpFox 4.8.6

Regards.

@PhpFoxJohnJr
Copy link
Author

Thank you very much!!! I really do appreciate all your work.

@PhpFoxJohnJr
Copy link
Author

PhpFoxJohnJr commented Jun 20, 2022

Can you double-check if this still works in 4.8.9. I attempted to invite through SMS and it did send the text and directed the user to the website but it said "Your invitation has expired or it was not valid" I tried on two different phones. My site is an invite-only site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants