Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GUI][Bug][Trivial] Console not showing output text when changing the wallet theme #1996

Open
ambassador000 opened this issue Nov 28, 2020 · 2 comments

Comments

@ambassador000
Copy link

  1. Start the wallet with Dark Theme
  2. Type any command in the console
  3. Switch from Dark to Light theme
  4. Command output is not visible anymore as well as the white text above "Welcome to the PIVX RPC..."
    GUI01

Additional:

  1. Run the wallet with Light theme
  2. Type any command in the console
  3. Switch from Light to Dark theme
  4. Command output will be visible, but with the different text color
    GUI02
@random-zebra
Copy link

Yes... both issues have the same root.
The stylesheet change in QTextDocument is applied only to to newly inserted text.
Old text is unchanged (so, e.g., white text becomes invisible when switching from dark to light mode).

I don't think there's a convenient QT function to repaint a QTextDocument with new stylesheet directly (@furszy ?).
Maybe the best solution is just to clear the console area, when the theme is changed, and re-write the "welcome" message (so at least the new style is applied to that).

@random-zebra random-zebra linked a pull request Mar 20, 2021 that will close this issue
@furszy
Copy link

furszy commented Mar 23, 2021

A bit delayed answer but here.. just commented in #2236 (comment) .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants