Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excluding a hostname #1297

Closed
MarcoMiltenburg opened this issue Nov 30, 2019 · 3 comments
Closed

Excluding a hostname #1297

MarcoMiltenburg opened this issue Nov 30, 2019 · 3 comments
Milestone

Comments

@MarcoMiltenburg
Copy link

I tried setting up a renewal for all host names of a site, except one. So I choose M: Create new certificate (full options) and 2: All bindings of an IIS website and choose the website. Then I get the choose to exclude host names:

 1: www.somedomain.nl
 2: somedomain.nl
 3: www.some-domain.nl
 4: some-domain.nl

 Press enter to include all listed hosts, or type a comma-separated lists of exclusions:

My first intuation was to type just 1 to exclude that host name. That didn't work. From issue #572 I understood that I should not enter the number but the actual full hostname. I find this counter-intuitive, especially since you navigate everywhere with just typing one letter or entering a number.

But OK, then I tried with entering the full host name:

 1: www.somedomain.nl
 2: somedomain.nl
 3: www.some-domain.nl
 4: some-domain.nl

 Press enter to include all listed hosts, or type a comma-separated lists of exclusions: www.somedomain.nl

 1: somedomain.nl
 2: www.some-domain.nl
 3: some-domain.nl
 <Enter>: Default

 Select primary domain (common name): 1

 [INFO] Target generated using plugin IISSite: somedomain.nl and 2 alternatives

 Suggested FriendlyName is '[IISSite] www.somedomain.nl', press enter to accept or type an alternative:

That seems to work better except that for the FriendlyName it still suggest a name that includes the host name that I just excluded. That seems like a bug to me.

@MarcoMiltenburg
Copy link
Author

Just realize that the suggested name for the FriedlyName is based on the actual website name of the website in IIS. So never mind that. But I would still like to suggest that instead of excluding host names by typing the names, it should (also) be possible to exclude them just by the number.

@WouterTinus
Copy link
Member

That would be a nice little usability improvement indeed.

@WouterTinus WouterTinus added this to the 2.1.2 milestone Dec 10, 2019
@WouterTinus
Copy link
Member

Included in the 2.1.2 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants