Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] #283

Closed
3 tasks done
QionghuaLiao opened this issue Oct 21, 2023 · 4 comments
Closed
3 tasks done

[Question] #283

QionghuaLiao opened this issue Oct 21, 2023 · 4 comments
Assignees
Labels
question Further information is requested

Comments

@QionghuaLiao
Copy link

Required prerequisites

Questions

Hi there,

Thank you so much for your valuable contributions on SRL!

I'm currently working with the PPOLag algorithm and I've noticed that it only supports Box-type Observation apace and Action space. I would like to know how I can use this algorithm with Discrete-type Observation space and Action space.

Additionally, I'm curious to know if all the SRL algorithms provided by this project default to supporting only Box-type Observation space and Action space. If there are any workarounds or alternative methods to handle Discrete spaces within this library, I would greatly appreciate any guidance or suggestions.

Thank you for your time and assistance!

@QionghuaLiao QionghuaLiao added the question Further information is requested label Oct 21, 2023
@Gaiejj
Copy link
Member

Gaiejj commented Oct 21, 2023

At present, OmniSafe does not support models with discrete action spaces and discrete observation spaces. In the spirit of contributing to the community as an open-source software library, we plan to introduce interfaces for environments with discrete action and observation spaces in the near future. We intend to implement this feature using PPO, using typical environments with discrete actions and observations from the Gymnasium as examples.

@Gaiejj Gaiejj self-assigned this Oct 21, 2023
@Gaiejj
Copy link
Member

Gaiejj commented Nov 13, 2023

#286 supports this feature. Feel free to use it or give us some comments.

@QionghuaLiao
Copy link
Author

That really helps. Thank you sooo much!

@Gaiejj
Copy link
Member

Gaiejj commented Apr 6, 2024

Closed due to no further questions. You're welcome to reopen it if you happen to have more issues.

@Gaiejj Gaiejj closed this as completed Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants