Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can you make .prettierignore file take prettier icon ? #172

Closed
abumalick opened this issue Dec 8, 2017 · 4 comments
Closed

Can you make .prettierignore file take prettier icon ? #172

abumalick opened this issue Dec 8, 2017 · 4 comments

Comments

@abumalick
Copy link

Hello,
thanks for your theme

Can you make .prettierignore file take prettier icon ?

https://prettier.io/docs/en/cli.html#ignore-path

@PKief
Copy link
Owner

PKief commented Dec 9, 2017

Yeah, sure, I'll add it soon. 👍

@gusbemacbe
Copy link

@PKief, do we have already an icon of prettier, right?

But does it make sense to set .prettierignore to prettier icon, using a customisation?

"material-icon-theme.files.associations": 
{
        ".prettierignore": "prettier"
}

@PKief PKief closed this as completed in 95fe666 Dec 10, 2017
@PKief
Copy link
Owner

PKief commented Dec 10, 2017

@gusbemacbe in this case it's better to have the prettier icon activated by default for the .prettierignore file. The .prettierignore file is widely used by the community and it's mentioned in the official documentation of prettier and therefore it should have the prettier icon by default.

@abumalick
Copy link
Author

Thank you very much 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants