Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match TypeScript config on tsconfig.*.json #1755

Closed
jeengbe opened this issue Nov 4, 2022 · 2 comments · Fixed by #1756
Closed

Match TypeScript config on tsconfig.*.json #1755

jeengbe opened this issue Nov 4, 2022 · 2 comments · Fixed by #1756

Comments

@jeengbe
Copy link
Contributor

jeengbe commented Nov 4, 2022

Describe the bug
TypeScript configuration files should match any tsconfig.*.json pattern. Currently, we only match a very limited set of tsconfing.(app|editor...).json and *.tsconfig.json,

Supporting the proposed pattern would align the icon with VSCode's explorer.fileNesting.patterns.

Alternatively, add the common patterns tsconfig.cjs.json, tsconfig.esm.json, tsconfig.mjs.json.

Current behaviour
image

Expected behaviour
image
(Maybe we could also get addition all CJS/ESM hints on the icon)

Computer information (please complete the following information):

  • Version: v4.21.0
@PKief PKief linked a pull request Nov 5, 2022 that will close this issue
@PKief
Copy link
Owner

PKief commented Nov 5, 2022

Hi @jeengbe, it's a reasonable feature request, but unfortunately this is not possible due to VS Code's limited extension API. See #330. I've added a PR to add these missing files names for you soon.

If you do not want to wait until I've published the changes on the marketplace, you can add these lines to your VS Code user settings:

  "material-icon-theme.files.associations": {
    "tsconfig.cjs.json": "tsconfig",
    "tsconfig.esm.json": "tsconfig",
    "tsconfig.mjs.json": "tsconfig"
  },

@jeengbe
Copy link
Contributor Author

jeengbe commented Nov 5, 2022

I understand, thanks for the linked issue and also adding the extensions.

@jeengbe jeengbe closed this as completed Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants