Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Icon Request] Typescript_svelte, Javascript_svelte #1993

Open
1 of 2 tasks
TheBlckbird opened this issue Jun 10, 2023 · 12 comments · May be fixed by #2009
Open
1 of 2 tasks

[Icon Request] Typescript_svelte, Javascript_svelte #1993

TheBlckbird opened this issue Jun 10, 2023 · 12 comments · May be fixed by #2009

Comments

@TheBlckbird
Copy link
Contributor

TheBlckbird commented Jun 10, 2023

Icon Type

  • File
  • Folder

File Names

  • +page.ts
  • +page.js
  • +page.server.ts
  • +page.server.js
  • +layout.ts
  • +layout.js
  • +server.ts
  • +server.js
  • +layout.server.js
  • +layout.server.ts
  • hooks.client.ts
  • hooks.client.js
  • hooks.server.ts
  • hooks.server.js

Graphic ideas

and the same for JS.

The icon should be the TS/JS icon but with the Svelte logo in a corner. Another idea was to change the color of the TS/JS icon and I think that it looks better than the other three examples. But I wanted to share them anyway.

Additional context
Are there other frameworks using these naming conventions? Then would we need to create an icon pack.

@suwermave
Copy link

First one looks cool!

@TheBlckbird
Copy link
Contributor Author

TheBlckbird commented Jun 18, 2023

Here are the SVGs with the correct colors

@mallowigi
Copy link

Not in favor of the idea though. What's the relation of page.js to svelte

@TheBlckbird
Copy link
Contributor Author

@mallowigi SvelteKit uses +page.ts and the other files for server side stuff or just scripts that belong to a specific route/layout

@TheBlckbird
Copy link
Contributor Author

I’ll just create a PR. If this feature is really not wanted, we can just close it.

@TheBlckbird TheBlckbird linked a pull request Jun 19, 2023 that will close this issue
@TheBlckbird
Copy link
Contributor Author

See #2009

@Zerotask
Copy link

To extend your list:

  • +layout.server.js/ts
  • hooks.client.js/ts
  • hooks.server.js/ts

In addition to that, I noticed that svelte.config.js does show a Svelte icon, but svelte.config.ts just shows a regular TS icon.

@TheBlckbird
Copy link
Contributor Author

Thanks, I will update it

@TheBlckbird
Copy link
Contributor Author

In addition to that, I noticed that svelte.config.js does show a Svelte icon, but svelte.config.ts just shows a regular TS icon.

It seems like svelte doesn't support ts for the config file yet. github.com/sveltejs/kit/pull/4031

@TheBlckbird
Copy link
Contributor Author

I don't think we should put the hooks in here as they are just too generic

@vidhanio
Copy link
Contributor

I don't think we should put the hooks in here as they are just too generic

maybe a new icon pack for svelte?

@TheBlckbird
Copy link
Contributor Author

I don't think we should put the hooks in here as they are just too generic

maybe a new icon pack for svelte?

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants