Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Add Storybook icon #235

Closed
bcanseco opened this issue Mar 29, 2018 · 5 comments
Closed

Request: Add Storybook icon #235

bcanseco opened this issue Mar 29, 2018 · 5 comments

Comments

@bcanseco
Copy link
Contributor

bcanseco commented Mar 29, 2018

Storybook is a UI dev sandbox. You can use it as an isolated environment for prototyping React/Angular/+ components. It's used by Airbnb, Squarespace, Coursera, and many others.

The icon should be applied to:

  • Folders named .storybook
  • Files that end in either of the following:
    • .stories.js
    • .stories.jsx
    • .story.js
    • .story.jsx

This is their icon:
storybook-icon ddf01037

@PKief
Copy link
Owner

PKief commented Mar 30, 2018

@bcanseco Thank you for the request. I had to adjust the icon to make it look better with the other icons in the theme. Right now, it would look like this:

Dark background:

storybook-background-dark

Light background:

storybook-background-light

Is this ok for you?

@bcanseco
Copy link
Contributor Author

bcanseco commented Mar 30, 2018

@PKief Looks great!

@PKief PKief closed this as completed in 8864d0a Mar 30, 2018
@PKief
Copy link
Owner

PKief commented Mar 30, 2018

@bcanseco I also tried to create a folder icon with this icon, but I was not very happy with it. The Storybook icon is not very suitable for a folder icon.

@bcanseco
Copy link
Contributor Author

@PKief No worries! I figured the folder look would be tricky with this logo. Thanks for adding the file icons!

@usulpro
Copy link

usulpro commented Jun 9, 2018

Hey guys, thanks for adding storybook icon to my favorite icon theme! 😀

But could you please consider to keep white internal parts since it looks so unusual with dark theme? 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants