Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if hidesExplorerArrows still requires reload #454

Closed
PKief opened this issue May 20, 2019 · 1 comment
Closed

Check if hidesExplorerArrows still requires reload #454

PKief opened this issue May 20, 2019 · 1 comment
Assignees
@PKief

Comments

@PKief
Copy link
Member

PKief commented May 20, 2019

It should be checked if the hidesExplorerArrows option still requires a reload of the whole editor because it's only a change of the JSON and not a change in the icons:

https://github.com/PKief/vscode-material-icon-theme/blob/02af51b75eacd14f81876f1b26c05280b38cd967/src/helpers/changeDetection.ts#L21

It's probably fixed in microsoft/vscode#71855 in VS Code v 1.34.
@PKief PKief self-assigned this May 21, 2019
@PKief
Copy link
Member Author

PKief commented May 21, 2019

Reload is not more required for "hidesExplorerArrows". Will be fixed soon.

@PKief PKief closed this as completed in c65d9a6 May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PKief PKief

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PKief