Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Icon Request] Firebase folder icon #555

Closed
Shubhamai opened this issue Oct 7, 2019 · 10 comments
Closed

[Icon Request] Firebase folder icon #555

Shubhamai opened this issue Oct 7, 2019 · 10 comments

Comments

@Shubhamai
Copy link

There's should a Firebase Icon. Hope you will add one. Thanks 馃槂馃榿

@PKief
Copy link
Owner

PKief commented Oct 7, 2019

Hi @Shubham2004-AI, we already have a Firebase icon:

{ name: 'firebase', fileNames: ['firebase.json', '.firebaserc'] },

Firebase icons

Are there some file extensions or file names missing for you?

@Shubhamai
Copy link
Author

Oh sorry, I was talking about Firebase Folder Icon

@PKief
Copy link
Owner

PKief commented Oct 8, 2019

Alright, what would be the name of a Firebase specific folder icon?

@AnthonyLenglet
Copy link

outside of a firebase folder icon, firebase also creates "firestore.rules" and "firestore.indexes.json" files when initializing a firebase project using the firebase cli, and those currently aren't marked with icons

@denosaurabh
Copy link

Hey @PKief , FireFolder can be ? That's not the best name but have you also any idea.

@smhmd
Copy link

smhmd commented Oct 25, 2019

@AnthonyLenglet

// settings.json
 "material-icon-theme.files.associations": {
    "firestore.rules": "firebase",
    "firestore.indexes.json": "firebase",
  },

or something like that. I did not test this; but, this is how you do it generally.

@PKief
Copy link
Owner

PKief commented Apr 2, 2020

Just added a firebase folder icon:

Collapsed Expanded
firebase folder icon collapsed firebase folder icon expanded

I also updated the firebase file icon a little bit so that it fits better to the folder icon:

File icon
update firebase file icon

@PKief PKief closed this as completed in cafcc5c Apr 2, 2020
@PKief PKief changed the title [Icon Request] Firebase Icon [Icon Request] Firebase folder icon Apr 2, 2020
@thewasif
Copy link

thewasif commented Aug 9, 2020

@PKief Icon should be displayed on folder name firebase.
.firebase is not mostly used. Can you change that?

@codercatdev
Copy link

@PKief I have been trying to get this to work by default with no luck, then I added below to .vscode/settings.json

  "material-icon-theme.folders.associations": {
    "firebase": "firebase",
  }

Also tried

  "material-icon-theme.folders.associations": {
  "firebase": "folder-firebase",
}

Still showing classic gray

image

@PKief
Copy link
Owner

PKief commented Dec 17, 2020

Hi @Ajonp, this is not working because you placed this config in the local workspace settings file. This is not supported right now (see #208). To make it work you have to put this config into your user settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants