Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add vlang #1009

Merged
merged 5 commits into from
Jul 12, 2021
Merged

add vlang #1009

merged 5 commits into from
Jul 12, 2021

Conversation

Milo123459
Copy link
Contributor

this add's vlang in

@Milo123459
Copy link
Contributor Author

Fix #1008

@abughurab16
Copy link

awesome i was just about to try adding it, glad u did already thanks!

@PKief PKief self-requested a review April 20, 2021 05:01
@Milo123459
Copy link
Contributor Author

Let me resolve conflicts

@Milo123459
Copy link
Contributor Author

Ok, @PKief anything I need to change?

@PKief PKief force-pushed the main branch 2 times, most recently from b670644 to 387e8ff Compare May 24, 2021 12:37
@Milo123459
Copy link
Contributor Author

@PKief please either tell me what i need to change or merge it. An update would be nice because it's very annoying.

@Milo123459
Copy link
Contributor Author

^ Adds icon for v.mod and vpkg.json

@Milo123459
Copy link
Contributor Author

@PKief is there some remote way I can get a review on this

This was referenced Jul 12, 2021
Copy link
Member

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Milo123459, sorry that it took so long but now I finally reviewed the icon and updated it to make it look more material:

Will be part of the next update! Thanks for contributing :)

@PKief PKief merged commit 0b7781e into material-extensions:main Jul 12, 2021
@Milo123459
Copy link
Contributor Author

Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants