Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gemini icon #1014

Merged
merged 2 commits into from
Apr 15, 2021
Merged

Add gemini icon #1014

merged 2 commits into from
Apr 15, 2021

Conversation

shreyasminocha
Copy link
Contributor

The gemini protocol doesn't seem to have a logo (!), so I just used a square with the "official colour" ¯\_(ツ)_/¯

@PKief PKief self-requested a review April 15, 2021 18:35
PKief
PKief reviewed Apr 15, 2021
View reviewed changes
Copy link
Member

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the suggestion. To be honest, I think a square is not so nice.

What would you think about this:

@shreyasminocha
Copy link
Contributor Author

Yeah, I like that better :)

PKief
PKief approved these changes Apr 15, 2021
View reviewed changes
Copy link
Member

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback, then we will go with this icon. If we think that we have to improve it in the future, we are free to do so ;)

@PKief PKief merged commit 965ffe8 into material-extensions:master Apr 15, 2021
@shreyasminocha shreyasminocha deleted the gemini branch April 15, 2021 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PKief PKief PKief approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shreyasminocha @PKief