Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Java '.class' file icons #1060

Merged
merged 3 commits into from
May 26, 2021
Merged

Add Java '.class' file icons #1060

merged 3 commits into from
May 26, 2021

Conversation

moxwel
Copy link
Contributor

@moxwel moxwel commented May 26, 2021 •
edited
Loading

This closes #433 and closes #1059

image

A new icon for .class files, the same as the Java icon, but in blue color.

@PKief PKief self-requested a review May 26, 2021 06:51
PKief
PKief approved these changes May 26, 2021
View reviewed changes
Copy link
Member

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much, I like it :) Just slightly updated the hue of the blue color so that it is a little bit brighter, but that doesn't makes lots of difference as you see:

image

Looks good, thanks again!

@PKief PKief merged commit e0df062 into material-extensions:main May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PKief PKief PKief approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Icon Request] .class file [icon req] .class file
2 participants
@moxwel @PKief