Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ember icon #1097

Merged
merged 6 commits into from Jun 23, 2021
Merged

Add Ember icon #1097

merged 6 commits into from Jun 23, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jun 20, 2021

@ghost
Copy link
Author

ghost commented Jun 21, 2021

This would benefit from upstream directory API support as described in microsoft/vscode#12493 (comment)

src/icons/fileIcons.ts Outdated Show resolved Hide resolved
Copy link
Member

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icon looks pretty good :)

@ghost ghost requested a review from PKief June 21, 2021 16:15
src/icons/fileIcons.ts Outdated Show resolved Hide resolved
src/icons/fileIcons.ts Outdated Show resolved Hide resolved
@ghost ghost requested a review from PKief June 23, 2021 12:01
Copy link
Member

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the modifications :)

@PKief PKief merged commit 1c94922 into material-extensions:main Jun 23, 2021
@ghost ghost deleted the ember branch June 23, 2021 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant