Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon request and bug report templates (Closes #1225 and #1227) #1226

Merged
merged 3 commits into from
Aug 26, 2021
Merged

Icon request and bug report templates (Closes #1225 and #1227) #1226

merged 3 commits into from
Aug 26, 2021

Conversation

mahyarmirrashed
Copy link
Contributor

Let me know what you think of this! I will create another issue and pull request for the template for bug reports.

@mahyarmirrashed mahyarmirrashed changed the title Addresses #1225 Icon request template (#1225) Aug 25, 2021
@mahyarmirrashed
Copy link
Contributor Author

We can also optionally add some labels to automatically be added. I think something like Icon Request would be great as well!

@mahyarmirrashed mahyarmirrashed changed the title Icon request template (#1225) Icon request template (Closes #1225) Aug 25, 2021
Copy link
Member

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it, looks awesome! Thank you very much, really appreciate such contributions! We will use these templates for now and see how it will work 😉

@PKief PKief merged commit aa2b698 into material-extensions:main Aug 26, 2021
@PKief
Copy link
Member

PKief commented Aug 26, 2021

Regarding the labels I need some time to think about it. I still have something in my mind with a generated changelog and automated release process for this extension. If you take a look at the changelog, there's basically a separation between added "File Icons", "Folder Icons", "Updated icons" and "Other changes". I would be open to change this pattern in regards of an highly automated generation of the changelog. The basis for such a generation would be the labels of the issues and / or the related PRs. But maybe it would be also fine if we just go with "Icon Featrues" (i.e. New or updated file, folder icons) and "Enhancements" (i.e. API changes, refactoring etc.)

As described here the creation of the changelog is right now the only manual step in the deployment process. I'd be curious if I could automate this process because it would safe me lots of time and would not be error-prone.

@mahyarmirrashed mahyarmirrashed changed the title Icon request template (Closes #1225) Icon request and bug report templates (Closes #1225 and #1227) Aug 26, 2021
@mahyarmirrashed
Copy link
Contributor Author

Regarding the aspect about the changelog @PKief , I think that you might want to check out what has been done for mongoosejs: https://github.com/Automattic/mongoose

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants