Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: hardhat #1377

Merged
merged 7 commits into from
Mar 6, 2022
Merged

feat: hardhat #1377

merged 7 commits into from
Mar 6, 2022

Conversation

bart-krakowski
Copy link
Contributor

This PR introduces icons for the config files of Hardhat.

Closes #1366

@PKief PKief force-pushed the main branch 6 times, most recently from c149f3c to 6ed12b6 Compare January 23, 2022 19:28
@PKief PKief self-requested a review March 6, 2022 13:19
PKief
PKief requested changes Mar 6, 2022
View reviewed changes
Copy link
Member

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icon looks nice, but in my opinion it would be better if we could use the icon of the Material Design Icons package:

https://materialdesignicons.com/icon/hard-hat

icons/hardhat.svg Outdated Show resolved Hide resolved
@PKief PKief merged commit 50d9faf into material-extensions:main Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PKief PKief PKief approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Icon Request] hardhat config
2 participants
@bart-krakowski @PKief