Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Otne icon #1431

Merged
merged 6 commits into from
May 6, 2022
Merged

feat: add Otne icon #1431

merged 6 commits into from
May 6, 2022

Conversation

beanflame
Copy link
Contributor

No description provided.

Copy link
Member

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi thank you for the icon suggestion :) To keep the icons consistent within this extension I try to avoid gradients and it's important to pick the colors of the Material Design Color palette.

What do you think about removing the gradient and picking a solid color instead, for instance like this:

otne file icon preview image

@beanflame
Copy link
Contributor Author

beanflame commented Mar 31, 2022

嗨,谢谢您的图标建议 :) 为了在此扩展中保持图标一致,我尽量避免渐变,并且选择Material Design Color 调色板的颜色很重要。

您如何看待删除渐变并选择纯色,例如:

otne 文件图标预览图像

well, My icon has been rewritten and updated
@PKief

otne 文件图标预览图像

@PKief PKief self-requested a review March 31, 2022 12:06
Copy link
Member

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much! Looks good to me :)

@PKief PKief merged commit 73786ae into material-extensions:main May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants