-
-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add folder icon for internal folder #1501
Open
aryaag
wants to merge
3
commits into
PKief:main
Choose a base branch
from
aryaag:feature/add-icon-for-internal-folder
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PKief
force-pushed
the
main
branch
3 times, most recently
from
November 18, 2023 10:30
640fb8a
to
d5912bb
Compare
@PKief - any chance of getting this merged? |
PreviewThank you for creating a pull request. This preview shows you how your changes will look on the different themes: You can find more information how to contribute in the contribution guidelines. |
okineadev
suggested changes
May 21, 2024
@@ -0,0 +1 @@ | |||
<?xml version="1.0" encoding="UTF-8" standalone="no"?> <svg clip-rule="evenodd" fill-rule="evenodd" stroke-linejoin="round" stroke-miterlimit="1.414" viewBox="0 0 24 24" xml:space="preserve" version="1.1" id="svg828" xmlns="http://www.w3.org/2000/svg" xmlns:svg="http://www.w3.org/2000/svg"><defs id="defs832" /><path d="M 19,20 H 4 A 2,2 0 0 1 2,18 V 6 C 2,4.89 2.89,4 4,4 H 9.9999997 L 12,6 h 7 c 1.097,0 2,0.903 2,2 H 4 v 10 l 2.14,-8 h 17.07 l -2.28,8.5 C 20.7,19.37 19.92,20 19,20 Z" fill="#e57373" style="clip-rule:evenodd;fill:#546e7a;stroke-linejoin:round;stroke-miterlimit:1.414" id="path1147" /><g id="layer1" /><g id="layer2"><path d="m 16.793167,8.3575817 c -0.32496,0 -0.649919,0.1234846 -0.916386,0.3834521 l -5.19935,5.1993502 c -0.513436,0.506936 -0.513436,1.325834 0,1.832771 l 5.19935,5.19935 c 0.506937,0.513436 1.325834,0.513436 1.832771,0 l 5.19935,-5.19935 c 0.513436,-0.506937 0.513436,-1.325835 0,-1.832771 L 17.709552,8.7410338 C 17.443085,8.4810663 17.118126,8.3575817 16.793167,8.3575817 m -0.649919,3.2495933 h 1.299837 v 3.899513 h -1.299837 v -3.899513 m 0,5.199351 h 1.299837 v 1.299837 h -1.299837 z" id="path963" style="fill:#cfd8dc;fill-opacity:1;stroke-width:0.649919" /></g></svg> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
<?xml version="1.0" encoding="UTF-8" standalone="no"?> <svg clip-rule="evenodd" fill-rule="evenodd" stroke-linejoin="round" stroke-miterlimit="1.414" viewBox="0 0 24 24" xml:space="preserve" version="1.1" id="svg828" xmlns="http://www.w3.org/2000/svg" xmlns:svg="http://www.w3.org/2000/svg"><defs id="defs832" /><path d="M 19,20 H 4 A 2,2 0 0 1 2,18 V 6 C 2,4.89 2.89,4 4,4 H 9.9999997 L 12,6 h 7 c 1.097,0 2,0.903 2,2 H 4 v 10 l 2.14,-8 h 17.07 l -2.28,8.5 C 20.7,19.37 19.92,20 19,20 Z" fill="#e57373" style="clip-rule:evenodd;fill:#546e7a;stroke-linejoin:round;stroke-miterlimit:1.414" id="path1147" /><g id="layer1" /><g id="layer2"><path d="m 16.793167,8.3575817 c -0.32496,0 -0.649919,0.1234846 -0.916386,0.3834521 l -5.19935,5.1993502 c -0.513436,0.506936 -0.513436,1.325834 0,1.832771 l 5.19935,5.19935 c 0.506937,0.513436 1.325834,0.513436 1.832771,0 l 5.19935,-5.19935 c 0.513436,-0.506937 0.513436,-1.325835 0,-1.832771 L 17.709552,8.7410338 C 17.443085,8.4810663 17.118126,8.3575817 16.793167,8.3575817 m -0.649919,3.2495933 h 1.299837 v 3.899513 h -1.299837 v -3.899513 m 0,5.199351 h 1.299837 v 1.299837 h -1.299837 z" id="path963" style="fill:#cfd8dc;fill-opacity:1;stroke-width:0.649919" /></g></svg> | |
<svg clip-rule="evenodd" fill-rule="evenodd" stroke-linejoin="round" stroke-miterlimit="1.414" viewBox="0 0 24 24" xml:space="preserve" version="1.1" id="svg828" xmlns="http://www.w3.org/2000/svg" xmlns:svg="http://www.w3.org/2000/svg"><defs id="defs832" /><path d="M 19,20 H 4 A 2,2 0 0 1 2,18 V 6 C 2,4.89 2.89,4 4,4 H 9.9999997 L 12,6 h 7 c 1.097,0 2,0.903 2,2 H 4 v 10 l 2.14,-8 h 17.07 l -2.28,8.5 C 20.7,19.37 19.92,20 19,20 Z" fill="#e57373" style="clip-rule:evenodd;fill:#546e7a;stroke-linejoin:round;stroke-miterlimit:1.414" id="path1147" /><g id="layer1" /><g id="layer2"><path d="m 16.793167,8.3575817 c -0.32496,0 -0.649919,0.1234846 -0.916386,0.3834521 l -5.19935,5.1993502 c -0.513436,0.506936 -0.513436,1.325834 0,1.832771 l 5.19935,5.19935 c 0.506937,0.513436 1.325834,0.513436 1.832771,0 l 5.19935,-5.19935 c 0.513436,-0.506937 0.513436,-1.325835 0,-1.832771 L 17.709552,8.7410338 C 17.443085,8.4810663 17.118126,8.3575817 16.793167,8.3575817 m -0.649919,3.2495933 h 1.299837 v 3.899513 h -1.299837 v -3.899513 m 0,5.199351 h 1.299837 v 1.299837 h -1.299837 z" id="path963" style="fill:#cfd8dc;fill-opacity:1;stroke-width:0.649919" /></g></svg> |
PKief
force-pushed
the
main
branch
2 times, most recently
from
June 12, 2024 20:23
eeb4f0e
to
b2e0fe4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
internal
is a common pattern across multiple languages and frameworksinternal
folder for internal packages [link]Changes in this PR
internal
folderplain grey
as it does not specific to any language or framework.folder-admin
icon(s)Screenshots (if appropriate):