Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flow - Cadence Icon Addition #1686

Merged
merged 9 commits into from
Sep 22, 2022
Merged

Flow - Cadence Icon Addition #1686

merged 9 commits into from
Sep 22, 2022

Conversation

yanukadeneth99
Copy link
Contributor

@PKief PKief self-requested a review September 11, 2022 19:35
PKief
PKief requested changes Sep 19, 2022
View reviewed changes
.vscode/settings.json Outdated Show resolved Hide resolved
src/icons/fileIcons.ts Outdated Show resolved Hide resolved
@PKief
Copy link
Member

PKief commented Sep 20, 2022

I just slightly updated the icon by removing the circled background to let the logo stand out a bit more:

Preview

@yanukadeneth99
Copy link
Contributor Author

Thanks @PKief! You're amazing.

@mallowigi
Copy link

Did the same :)

@yanukadeneth99
Copy link
Contributor Author

Did the same :)

Sorry, didn't get you.

@PKief PKief merged commit 1efb560 into material-extensions:main Sep 22, 2022
@yanukadeneth99
Copy link
Contributor Author

Thanks guys! Good stuff.

@PKief
Copy link
Member

PKief commented Sep 23, 2022

Thanks guys! Good stuff.

Thanks, will trigger a new release in the next few days :)

Anselmoo pushed a commit to Anselmoo/vscode-material-icon-theme that referenced this pull request Nov 5, 2022
@yanukadeneth99 @PKief @Anselmoo
Flow - Cadence Icon Addition (material-extensions#1686)
9fcde80 
* Added Cadence

* Reverted Lint addition

* Corrections

* Fix settings

* Reset formatting of settings.json

* Fix formatting issues

* Fix file extensions

* Update cadence file icon

Co-authored-by: Philipp Kief <philipp.kief@gmx.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PKief PKief PKief approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yanukadeneth99 @PKief @mallowigi