-
-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added swagger icon #1718
Added swagger icon #1718
Conversation
Hi @PKief, I'd be interested to know if anything else is needed for this PR? Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The icon would require some adjustments before being merged:
- remove the white border around the green circle
- make the curly brackets and the three dots transparent
- add some space around the icon so that it does not go to the edges
These are the guidelines with which I'll make sure that every icon fits to the other icons. WIll also shortly update that in the contributions guidelines.
These changes should now be addressed, please review @PKief |
Hi @zm-cttae , Swagger was the name when it originally came out. Since then it has been taken over by the OpenAPI Initiative. Swagger now only provides extra tools but the spec is called openapi. Thanks! |
I originally started with the OpenApi icons, but but the changes in terms of colouring to it made it less recognisable which is why I opted for the Swagger icon. Happy to swap the icon to the one in #1072 if preferred |
Here's an openapi icon with correct color: <svg xmlns="http://www.w3.org/2000/svg" version="1.1" viewBox="0 0 24 24"><path d="m19.534 2a2.459 2.459 0 00-1.744.722 2.466 2.466 0 00-.465 2.84l-5.372 5.372a2.466 2.466 0 101.113 1.115l5.372-5.373a2.466 2.466 0 002.84-3.954 2.457 2.457 0 00-1.745-.722zm-8.677 2.285-.178.005-.178.004a8.945 8.945 0 00-1.113.114l-.025.004a9.296 9.296 0 00-.242.045l-.09.019-.15.033-.028.006a8.888 8.888 0 00-2.124.793c-.044.023-.087.05-.13.073a9.92 9.92 0 00-.156.088l-.115.065-.002.001-.008.004-.03.017v.001l.093.153 2.625 4.36c.051-.032.104-.06.156-.088a3.98 3.98 0 01.16-.081 3.59 3.59 0 011.179-.33 3.696 3.696 0 01.356-.02zm.357.008v5.278a3.668 3.668 0 01.799.174l3.884-3.885a9.363 9.363 0 00-.44-.287l-.02-.013-.14-.083-.082-.046-.083-.046-.143-.078-.022-.012a8.776 8.776 0 00-.95-.426l-.025-.01c-.07-.026-.141-.053-.212-.078a8.913 8.913 0 00-1.774-.421l-.074-.01-.074-.008-.144-.016-.04-.004a5.901 5.901 0 00-.17-.014l-.066-.004-.146-.008zm-5.229 1.455c-.126.082-.25.167-.371.256a8.948 8.948 0 00-.762.629l3.718 3.717.015.015c.04-.033.082-.065.124-.096l-.01-.015zm-1.39 1.132c-.043.043-.082.087-.123.13-.042.043-.084.085-.124.129a8.847 8.847 0 00-.752.932l-.033.046a5.782 5.782 0 00-.152.229l-.028.043a8.832 8.832 0 00-1.375 4.397c-.003.06-.004.12-.005.178l-.003.18h5.264c0-.06.006-.12.01-.18.002-.06.003-.119.009-.178a3.572 3.572 0 01.794-1.918c.038-.045.08-.088.12-.132.04-.044.077-.09.12-.133zm13.545 1.22-3.886 3.886c.089.261.147.529.175.8h5.277l-.004-.078a8.186 8.186 0 00-.008-.142l-.005-.07-.014-.167-.003-.044a14.384 14.384 0 00-.022-.201v-.007a10.656 10.656 0 00-.028-.207 8.9 8.9 0 00-.272-1.245l-.003-.008a8.28 8.28 0 00-.058-.19 8.21 8.21 0 00-.065-.195l-.016-.046a6.293 6.293 0 00-.08-.217 6.191 6.191 0 00-.048-.121l-.038-.095-.04-.094-.052-.12a11.05 11.05 0 00-.098-.21l-.02-.044-.08-.162-.011-.021a10.388 10.388 0 00-.094-.177l-.003-.007a8.81 8.81 0 00-.504-.818zm-3.692 5.043c0 .06-.006.119-.009.178-.002.06-.003.12-.01.179a3.573 3.573 0 01-.794 1.918c-.037.046-.08.088-.12.132-.04.044-.077.09-.12.133l3.723 3.723c.043-.042.082-.087.124-.13.041-.042.084-.085.124-.128a8.94 8.94 0 00.753-.936c.01-.012.018-.025.027-.037a9.765 9.765 0 00.152-.228l.034-.053a8.828 8.828 0 001.372-4.394c.003-.06.004-.12.005-.179.001-.06.003-.119.002-.178zm-12.44.358c0 .026 0 .05.002.076.002.05.006.1.009.149a8.074 8.074 0 00.019.236l.004.038c.006.063.012.126.02.19l.002.018.027.204v.003c.061.42.152.838.273 1.248l.002.004c.019.065.038.129.059.193l.004.012a9.456 9.456 0 00.062.184l.015.044.054.15.026.067.048.123.038.093.04.096.052.118.03.069.067.14.022.046.078.16.013.023c.03.059.062.118.093.176l.004.008.02.035 4.507-2.715.017-.01a3.584 3.584 0 01-.33-1.178h-.02zm.42 2.37-.172.05.002.004zm5.354-.876-4.512 2.718c.069.115.14.228.215.338l.008.012.002.004.006.011.001.002a.707.707 0 00.019.026v.002h.001c.079.117.159.23.242.342l.006.007.005.007c.036.047.072.096.11.143l.014.018c.038.05.077.097.117.145l.029.035.108.127.047.054.094.105.053.058.024.025.069.075.028.03.126.127 3.722-3.723a3.637 3.637 0 01-.122-.13 3.56 3.56 0 01-.115-.137 3.478 3.478 0 01-.097-.125 3.643 3.643 0 01-.104-.145c-.033-.05-.066-.1-.096-.15zm5.347.926a3.478 3.478 0 01-.125.096l.01.016 2.714 4.506c.126-.082.25-.167.371-.256a9.034 9.034 0 00.762-.63l-3.717-3.717zm-4.547.002-.013.013-3.717 3.717c.019.018.037.036.057.053l.106.094c.018.016.035.033.054.048l.127.107.034.028c.048.04.096.079.145.117l.019.015c.052.042.106.082.159.123.003.001.005.002.006.004a8.905 8.905 0 00.696.47l.025.016a9.156 9.156 0 00.446.251l.02.011a8.212 8.212 0 00.411.2l.132-.32 1.87-4.541.006-.017a3.548 3.548 0 01-.583-.389zm4.126.294c-.05.031-.104.059-.156.087a3.6 3.6 0 01-1.701.429 3.59 3.59 0 01-1.026-.15c-.057-.017-.112-.038-.168-.058-.056-.02-.113-.038-.168-.06l-1.869 4.536-.073.178-.063.152v.001l.014.006.016.006.004.001c.044.018.088.034.133.05.055.022.11.044.166.064.029.01.056.023.085.033a8.893 8.893 0 001.807.432l.072.01.076.008c.047.006.094.01.142.015l.036.004a8.664 8.664 0 00.387.027l.094.004.122.004c.059.002.117.002.176.002h.042a8.88 8.88 0 001.47-.122l.024-.004.154-.028.088-.017a9.857 9.857 0 00.241-.051 8.916 8.916 0 002.151-.799c.044-.023.088-.05.132-.073.052-.028.103-.058.155-.088l.108-.061.002-.002h.001l.002-.001c.002-.002.005-.002.007-.003l.035-.021-.092-.152-.092-.153zm2.684 4.533.034-.02z" fill="#7cb342"/></svg> |
Personally I would prefer the OpenApi icons Thanks! |
I can provide one that's green-grey and also looks material one sec |
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24"><path fill="#8bc34a" d="M10.86 4.29h-.36a8.95 8.95 0 0 0-1.11.12h-.03a9.3 9.3 0 0 0-.24.05l-.09.02-.15.03h-.03a8.89 8.89 0 0 0-2.12.8l-.13.07a9.92 9.92 0 0 0-.16.09l-.11.06h-.01l-.03.03.09.15 2.63 4.36.15-.09a3.98 3.98 0 0 1 .16-.08 3.59 3.59 0 0 1 1.18-.33 3.7 3.7 0 0 1 .36-.02V4.3zM5.98 5.75 5.61 6a8.95 8.95 0 0 0-.76.63l3.72 3.72.02.02.12-.1-.01-.02-2.72-4.5zm8.47 7.4-.01.17-.01.18a3.57 3.57 0 0 1-.8 1.92l-.11.13c-.04.04-.08.1-.13.13l3.73 3.73.12-.13.12-.13a8.94 8.94 0 0 0 .76-.94l.03-.03a9.77 9.77 0 0 0 .15-.23l.03-.06a8.83 8.83 0 0 0 1.37-4.39v-.18l.01-.18h-5.26zM2 13.5v.08l.01.15a8.07 8.07 0 0 0 .02.23V14l.02.19v.02l.03.2c.06.42.15.84.27 1.25l.07.2v.01a9.46 9.46 0 0 0 .06.19l.02.04.05.15.03.07.04.12.04.1.04.09.05.12.04.07.06.14.02.04.08.16.01.03.1.17.02.04 4.5-2.71.03-.01a3.58 3.58 0 0 1-.33-1.18H2zM7.78 15 3.27 17.7l.21.34.01.01.01.02a.7.7 0 0 0 .02.03l.24.34h.01v.01l.11.15.02.02.12.14.02.03.11.13.05.06.1.1.05.06.02.02.07.08.03.03.12.13 3.73-3.73a3.64 3.64 0 0 1-.13-.13 3.56 3.56 0 0 1-.11-.13 3.48 3.48 0 0 1-.1-.13 3.64 3.64 0 0 1-.1-.14l-.1-.15zm4.93 1.22-.16.08a3.6 3.6 0 0 1-1.7.43 3.59 3.59 0 0 1-1.03-.15l-.16-.05a2.97 2.97 0 0 1-.17-.07L7.62 21l-.07.18-.07.15h.02l.01.01.14.05.17.07c.03 0 .05.02.08.03a8.9 8.9 0 0 0 1.8.43l.08.01.08.01.14.02h.04a8.66 8.66 0 0 0 .38.03h.44a8.88 8.88 0 0 0 1.47-.11h.02l.15-.04.1-.01a9.86 9.86 0 0 0 .23-.05 8.92 8.92 0 0 0 2.15-.8l.14-.08.15-.08.1-.06h.01l.01-.01.04-.02-.1-.15-.09-.16-2.53-4.2z"/><path fill="#689f38" d="M11.21 4.3v5.27a3.67 3.67 0 0 1 .8.17l3.89-3.88a9.36 9.36 0 0 0-.44-.29h-.02l-.14-.1-.09-.04-.08-.05-.14-.07-.02-.02a8.78 8.78 0 0 0-.95-.42l-.03-.01-.21-.08A8.91 8.91 0 0 0 12 4.36l-.08-.01h-.07l-.14-.02h-.05a5.9 5.9 0 0 0-.17-.02h-.06l-.15-.01h-.07zM4.6 6.87l-.13.13-.12.13a8.85 8.85 0 0 0-.75.93l-.04.05a5.78 5.78 0 0 0-.15.23l-.03.04a8.83 8.83 0 0 0-1.37 4.4v.17l-.01.18h5.26l.01-.18.01-.17a3.57 3.57 0 0 1 .8-1.92c.03-.05.08-.09.12-.13.04-.05.07-.1.12-.14L4.6 6.88zM18.14 8.1l-3.89 3.89c.1.26.15.52.18.8h5.28v-.08a8.19 8.19 0 0 0-.02-.14v-.07l-.01-.17v-.04a14.38 14.38 0 0 0-.03-.2v-.01a10.66 10.66 0 0 0-.03-.21 8.9 8.9 0 0 0-.27-1.24v-.01a8.28 8.28 0 0 0-.06-.2 8.21 8.21 0 0 0-.07-.19l-.01-.04a6.3 6.3 0 0 0-.08-.22 6.2 6.2 0 0 0-.05-.12l-.04-.1-.04-.1-.05-.11a11.05 11.05 0 0 0-.1-.21l-.02-.04-.08-.17V9.1a10.39 10.39 0 0 0-.1-.17v-.01a8.81 8.81 0 0 0-.5-.82zm-5.01 7.82a3.48 3.48 0 0 1-.13.1l.01.01 2.72 4.5.37-.25a9.03 9.03 0 0 0 .76-.63l-3.72-3.71-.01-.02zm-4.55 0-.01.02-3.72 3.71.06.06.1.1c.02 0 .04.02.06.04l.13.1.03.03.15.12.01.02.16.12a8.9 8.9 0 0 0 .7.47l.03.02a9.16 9.16 0 0 0 .45.25l.02.01a8.21 8.21 0 0 0 .4.2l.14-.32 1.87-4.54v-.02a3.55 3.55 0 0 1-.58-.39z"/><path fill="#424242" d="M19.53 2a2.46 2.46 0 0 0-1.74.72 2.47 2.47 0 0 0-.47 2.84l-5.37 5.37a2.47 2.47 0 1 0 1.12 1.12l5.37-5.37a2.47 2.47 0 0 0 2.84-3.96A2.46 2.46 0 0 0 19.53 2z"/></svg> |
6a2b645
to
65a7ed2
Compare
65a7ed2
to
09d3131
Compare
I've added the openapi icon and kept the swagger one so that swagger and openapi files can be distinguished at a glance rather than having to rely on the property at the top of the file |
Hi @PKief, could this be reviewed again please |
Hi @PKief , wondering if you could take a look please |
640fb8a
to
d5912bb
Compare
PreviewThank you for creating a pull request. This preview shows you how your changes will look on the different themes: You can find more information how to contribute in the contribution guidelines. |
Hi @PKief, would you be able to re-review please |
PreviewThank you for creating a pull request. This preview shows you how your changes will look on the different themes: You can find more information how to contribute in the contribution guidelines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, it's looking good to me now. I just added an additional openapi SVG icon to differentiate between light and dark backgrounds.
Can this now be merged? @PKief |
Merge SuccessfulThanks for your contribution! 🎉 The changes will be part of the upcoming update on the marketplace. |
Added icon for openapi/swagger definitions. The source of the icon is the Swagger-API GitHub. the colours have been tweaked slightly to fall inline with the material colours. The licence for Swagger API is here. I've added a reference to the source of the icon in the README. Don't know if this is enough or if more would need to be done