Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix contributors line breaks for marketplace preview #551

Closed
wants to merge 2 commits into from
Closed

fix contributors line breaks for marketplace preview #551

wants to merge 2 commits into from

Conversation

yardenshoham
Copy link
Contributor

@yardenshoham yardenshoham commented Oct 4, 2019

Closes #547

This PR changes the contributors script and adds a line break every 16 contributors.

@PKief PKief self-requested a review October 6, 2019 09:21
Copy link
Member

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much, I was very excited about your pull request. However, I have now decided to generate the list as an image, so that the problem on the Marketplace will also be solved. I also liked your solution very much, but it has the disadvantage that the list outside the Marketplace is not as responsive if it is displayed directly in VS Code, for example:

image

If it is an image, it can be scaled to 100% and this problem is solved:

image

Once again, I would like to thank you for your work 👍

@PKief PKief closed this Oct 6, 2019
@PKief
Copy link
Member

PKief commented Oct 6, 2019

By the way, you can already see the new version here:
https://github.com/PKief/vscode-material-icon-theme/blob/master/README.md

Of course, the picture has the disadvantage that you can no longer click on the individual profile pictures. I solved this by redirecting you to the GitHub page, which lists all contributors. It's a compromise one can live with, I think 😄

@yardenshoham
Copy link
Contributor Author

By the way, you can already see the new version here:
https://github.com/PKief/vscode-material-icon-theme/blob/master/README.md

Of course, the picture has the disadvantage that you can no longer click on the individual profile pictures. I solved this by redirecting you to the GitHub page, which lists all contributors. It's a compromise one can live with, I think 😄

I believe a better solution exists. Let's use all-contributors. It's a fairly generic solution (which also break lines nicely).

@PKief
Copy link
Member

PKief commented Oct 7, 2019

Thanks for the advice. I will think about using an external library in the future. However, it is important to me that the readme does not need too much space for such a collection. I think that we can use the current solution quite well for now.

@yardenshoham yardenshoham deleted the marketplace-contributors branch October 30, 2019 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contribution list does not break images on marketplace
2 participants