Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add twine icon #873

Merged
merged 7 commits into from
Nov 17, 2020
Merged

add twine icon #873

merged 7 commits into from
Nov 17, 2020

Conversation

arohman84
Copy link
Contributor

twine

@arohman84
Copy link
Contributor Author

i have an error when using this icon for custom svg in my end, closing this to post the issue

@arohman84 arohman84 closed this Oct 28, 2020
@arohman84 arohman84 reopened this Oct 28, 2020
@PKief
Copy link
Member

PKief commented Nov 8, 2020

Thanks, but the icon needs to be improved before merging. Instead of having color gradients we should use material colors instead. For the area where the green part overlaps the blue part we could use a mixed color of blue and green, which would be something similar to cyan. Or we simply let the green part overlap the blue part completely, should try both versions.

Here's a tool to find some material colors https://pkief.github.io/material-color-converter/. If you like you can try to change the SVG as described. Otherwise I can also take it over, but feel free to try it out :)

@PKief PKief self-requested a review November 8, 2020 13:09
@arohman84
Copy link
Contributor Author

Thanks, but the icon needs to be improved before merging. Instead of having color gradients we should use material colors instead. For the area where the green part overlaps the blue part we could use a mixed color of blue and green, which would be something similar to cyan. Or we simply let the green part overlap the blue part completely, should try both versions.

Here's a tool to find some material colors https://pkief.github.io/material-color-converter/. If you like you can try to change the SVG as described. Otherwise I can also take it over, but feel free to try it out :)

please do as you wish for the icon, i'm totally noob for this icon modif. thx before

@PKief
Copy link
Member

PKief commented Nov 10, 2020

This is how it could look like:

image

What do you think?

@arohman84
Copy link
Contributor Author

arohman84 commented Nov 11, 2020

This is how it could look like:

image

What do you think?

excellent, thx a alot. can't wait for the next updates and tell to the communities

@PKief PKief merged commit 955bc11 into material-extensions:master Nov 17, 2020
Copy link
Member

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the feedback 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants