Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync version key value #897

Merged
merged 2 commits into from
Dec 3, 2020
Merged

Sync version key value #897

merged 2 commits into from
Dec 3, 2020

Conversation

sandy081
Copy link
Contributor

@PKief PKief self-requested a review November 30, 2020 17:05
PKief
PKief approved these changes Dec 3, 2020
View reviewed changes
Copy link
Member

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the changes! Didn't know about the API changes yet for the global state regarding the setKeysForSync method. This will definitely improve the welcome experience 👍

@PKief PKief merged commit d6c7fc1 into material-extensions:master Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PKief PKief PKief approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not show welcome message if installed by Settings Sync feature of VS Code
2 participants
@sandy081 @PKief