-
-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lerna.json icon #956
Add lerna.json icon #956
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks better, could you please add a color to it? The black color does not really fit to the bright style of the other icons. Simply pick one of the colors shown in this palette (except black):
Colour chosen is inline with colours on lerna.js.org
Up |
b670644
to
387e8ff
Compare
It is marginal improvement but will suck at 16px (smaller than this text I've written). I think we should modify font-awesome's |
Could you recolor it |
Actually I'll open another pull for it :) |
…theme into pr/jamiehaywood/956
@jamiehaywood I just looked into it and I don't really like it, to be honest 🙈 I also tried out another dragon icon but it's not that nice - and not similar to the actual lerna icon: I'm not quite sure if one can recognize it as a dragon if the icon is so small in the file explorer. Probably we need more ideas for this. Or we just live with the JSON icon. I don't think it's so bad if a separate logo doesn't appear for everything. |
@4086606 Yeah that would be ok I think. Could you update this PR so that I can review the icon? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@4086606 I think it's suitable like that, will be merged ;) Thanks for the contribution 👍
closes #955