Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lerna.json icon #956

Merged
merged 14 commits into from
Jul 19, 2021
Merged

Add lerna.json icon #956

merged 14 commits into from
Jul 19, 2021

Conversation

jamiehaywood
Copy link
Contributor

closes #955

Copy link
Member

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better, could you please add a color to it? The black color does not really fit to the bright style of the other icons. Simply pick one of the colors shown in this palette (except black):

https://pkief.github.io/material-color-converter/

@jamiehaywood
Copy link
Contributor Author

@PKief PKief self-requested a review April 30, 2021 21:25
@G21LXDR
Copy link

G21LXDR commented May 6, 2021

Up

@PKief PKief force-pushed the main branch 2 times, most recently from b670644 to 387e8ff Compare May 24, 2021 12:37
@ghost
Copy link

ghost commented May 26, 2021

It is marginal improvement but will suck at 16px (smaller than this text I've written). I think we should modify font-awesome's dragon emoji to our needs. https://upload.wikimedia.org/wikipedia/commons/d/da/Font_Awesome_5_solid_dragon.svg

@ghost
Copy link

ghost commented May 27, 2021

Could you recolor it #5c6bc0 instead? The current color #5e35b1 doesn't work well with dark gray

@ghost
Copy link

ghost commented May 27, 2021

Actually I'll open another pull for it :)

@jamiehaywood
Copy link
Contributor Author

@PKief any movement on this - do you like @4086606's changes?

@PKief
Copy link
Member

PKief commented Jul 12, 2021

@jamiehaywood I just looked into it and I don't really like it, to be honest 🙈

I also tried out another dragon icon but it's not that nice - and not similar to the actual lerna icon:

I'm not quite sure if one can recognize it as a dragon if the icon is so small in the file explorer.

Probably we need more ideas for this. Or we just live with the JSON icon. I don't think it's so bad if a separate logo doesn't appear for everything.

@ghost
Copy link

ghost commented Jul 12, 2021

My second attempt, might be worth implementing? (300% zoom)

@PKief
Copy link
Member

PKief commented Jul 12, 2021

@4086606 Yeah that would be ok I think. Could you update this PR so that I can review the icon? :)

Copy link
Member

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@4086606 I think it's suitable like that, will be merged ;) Thanks for the contribution 👍

@PKief PKief merged commit 329602f into material-extensions:main Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add lerna fileName
3 participants