You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In one of our internal projects, plc check spends a good chunk of time in the resolver.
We should at least investigate if there are some potential performance gains.
(Note, this profile was done with --threads 1)
The text was updated successfully, but these errors were encountered:
to me it looks like that the long plateau does not reflect the time spent annotating, rather than the time spent waiting for a free thread from the threadpool to annotate (which happens in parallel to annotating). I suspect that what we see here is the behavior of the Par_Iter in rayon, when you only give it 1 thread.
I think we should at least see the TypeAnnotator::visit_unit(...) as well on this stack if it is really work spent in the annotation.
can we maybe have a call or something and look together - I sometimes find it hard to read flamegraphs correctly. maybe we can discuss it together.
Sadly no but it should be reproducible, might do that tomorrow. I did some further quick (time-based) profiling and got the following results (again with --threads=1). Does this mean the assumption with rayon is incorrect? Do we need to look into visit_statement_control? Anyways, I'll take a closer look at this tomorrow and perhaps ping you if you have time.
In one of our internal projects,
![Screenshot 2024-03-28 at 12 30 29](https://private-user-images.githubusercontent.com/29666622/317708969-5c494433-c696-4d27-853a-3fd68bd8d1c5.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjAxOTgwNjEsIm5iZiI6MTcyMDE5Nzc2MSwicGF0aCI6Ii8yOTY2NjYyMi8zMTc3MDg5NjktNWM0OTQ0MzMtYzY5Ni00ZDI3LTg1M2EtM2ZkNjhiZDhkMWM1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzA1VDE2NDI0MVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWI1MGQxN2JlMGE1YzU3ODk2NDA2NWNkNWQ3YzlhZDZkZDBkYmNiNDIxMWMwMDYyMjBjOGVlY2QxYTE3NDllMzQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.76YkUVZoBR_8ME-pI53It9mJDI6ktohJNK60oWqrFEI)
plc check
spends a good chunk of time in the resolver.We should at least investigate if there are some potential performance gains.
(Note, this profile was done with
--threads 1
)The text was updated successfully, but these errors were encountered: