Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows Physics instantiation without Phase, and ability to associate with Phase afterward #1671

Closed
jgostick opened this issue Oct 5, 2020 · 3 comments
Labels

Comments

@jgostick
Copy link
Member

jgostick commented Oct 5, 2020

This is pretty subtle, but would help make the code more flexible and forgiving. We've been doing several of these sort of relaxing of conditions lately, so this is part of a larger change. This is stemming from the new PNM IO class, which needs instantiation and object associations to be as flexible as possible (ie. the ability to create things in opposite orders).

@jgostick
Copy link
Member Author

jgostick commented Oct 5, 2020

After digging into the code, I see that we already 'try' to allow this, but it doesn't work. The project look-up breaks when no phase is given. I will tag this as a bug.

@jgostick
Copy link
Member Author

We already support this, BUT it breaks if the physics has any models on it. The init should be changed add 'freeze_models' to the settings if phase is None.

@jgostick
Copy link
Member Author

closed by #1674

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant