Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coordinates of the new pore after merging pores #693

Closed
ma-sadeghi opened this issue Apr 11, 2017 · 3 comments
Closed

Coordinates of the new pore after merging pores #693

ma-sadeghi opened this issue Apr 11, 2017 · 3 comments
Assignees
Milestone

Comments

@ma-sadeghi
Copy link
Member

Currently, the coordinates of the new pore after merging pores is calculated as the mean of the merged pores. This is OK as long as the merged pores are roughly the same size. However, when merging a bunch of small pores and a big pore, the coordinates of the new pore is skewed towards the small ones since they have more weight when averaging the coordinates. Here's what I mean:

figure_1-1

I think the new pore should be placed in the centroid of the convex hull of the merged pores.

@jgostick jgostick added this to the V1.X milestone May 8, 2017
@jgostick
Copy link
Member

This could be solved by finding the coordinates of all the neighbors of the new pore, and taking the average of those (which is akin to find the centroid of the new region). This would also be subject to skewing though if the new neighbors are much different in size.

@jgostick jgostick modified the milestones: V1.X, V2+ Jul 9, 2018
@TomTranter
Copy link
Contributor

Did this ever get addressed?

@ma-sadeghi
Copy link
Member Author

This is now addressed in PR #1191.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants