Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should n_max be changed to maxiter? #654

Closed
jgostick opened this issue Mar 9, 2022 · 1 comment
Closed

should n_max be changed to maxiter? #654

jgostick opened this issue Mar 9, 2022 · 1 comment

Comments

@jgostick
Copy link
Member

jgostick commented Mar 9, 2022

In the rsa function we use n_max to limit the number of spheres added. To be more consistent I think these should be changed to maxiter. Note that we use ncylinders in the cylinders function, but also have a maxiter to control how many times it iterates to find the desired porosity.

@jgostick
Copy link
Member Author

I think n_max is correct. maxiter implies there is some trial-and-error going on, but really rsa just inserts spheres until the desired volume fraction is reach, or no more room is found. It's not really an iteration. I find that I do use the n_max argument quite often to get an image of just a few spheres.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant