Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW will produce error after boundary_faces specification. #76

Closed
Zohaib-Atiq opened this issue Oct 8, 2018 · 1 comment
Closed

SNOW will produce error after boundary_faces specification. #76

Zohaib-Atiq opened this issue Oct 8, 2018 · 1 comment
Assignees
@Zohaib-Atiq
Labels
bug PR tag for bug fixes

Comments

@Zohaib-Atiq
Copy link
Contributor

The new implementation of SNOW will produce error after boundary_faces specification. Its because regions and image have different shapes and we cannot multiply regions*im. Although this scheme will work without making boundary cells because regions are not padded so the shape remains same as of image.
@Zohaib-Atiq Zohaib-Atiq added the bug PR tag for bug fixes label Oct 8, 2018
@Zohaib-Atiq Zohaib-Atiq self-assigned this Oct 8, 2018
@Zohaib-Atiq
Copy link
Contributor Author

#77 resolved. @jgostick please review. I have made a separate function in snow_n that labels boundary cells but since snow_n will be added late so SNOW will have some extra bit of lines of code for some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Zohaib-Atiq Zohaib-Atiq

Labels
bug PR tag for bug fixes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jgostick @Zohaib-Atiq