Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement recommend algorithm 1 at main #14

Merged
merged 10 commits into from Sep 3, 2021
Merged

Conversation

dldks321
Copy link
Contributor

@dldks321 dldks321 commented Sep 2, 2021

This revision includes:

Changes

1.Add Smith-Waterman Algorithm based recommendation system
2.Changed the epsilon value proportionality to have the same effect as the recommendation system 2.

References

1.https://en.wikipedia.org/wiki/Smith%E2%80%93Waterman_algorithm
2.https://developers.google.com/maps/documentation/places/web-service/details

@lijm1358 lijm1358 force-pushed the server-recommend1 branch 3 times, most recently from d2b485b to e18adfd Compare September 3, 2021 04:21
Copy link
Collaborator

@lijm1358 lijm1358 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed way to receive api key along with docker, and changed urllib to requests cause codacy shows security issue about urllib.
Other changes were minor bug fixes, and refactoring.

LGTM, I think it'll be ok to merge now 😀

@Snowapril Snowapril merged commit 126b58c into main Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants