Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trained lambda_CE is not correct for HMS-HMS grids #279

Open
ZepeiX opened this issue Mar 15, 2024 · 2 comments
Open

Trained lambda_CE is not correct for HMS-HMS grids #279

ZepeiX opened this issue Mar 15, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@ZepeiX
Copy link
Contributor

ZepeiX commented Mar 15, 2024

In HMS-HMS grids, some binaries go to unstable MT but the donor stars have no envelope. These could happen when the donor is still a MS or a stripped star or more generally, partially stripped star with H abundance < what is need to define the core/envelope boundary.
Then, the lambda_CE is set to be 1e99, which would mess up the training because all the lambda are normalized before training. The proposed fix is to set these lambda to Nan and exclude them from normalization and training.

@ZepeiX ZepeiX added the bug Something isn't working label Mar 15, 2024
@philipp-rajah
Copy link
Contributor

@ZepeiX I am unsure how to create a criterion to exclude certain binaries from the interpolation of the lambda values. Should I exclude the binaries that are in unstable MT where the donor stars have no envelope? How do I determine whether this is true? I'm not sure which parameter indicates the envelope and the units of that parameter.

@ZepeiX
Copy link
Contributor Author

ZepeiX commented May 15, 2024

@philipp-rajah I think this is supposed to be fixed in the PR Matthias posted above #281.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants