You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The distribution metallicity from the TNG simulation has incorrect weights at the high metallicity end, because of 2 reasons:
The code uses interp1d to extrapolate the cumulative density function. This results in CDF values above 1 due to the extrapolation. This should not happen.
Metallicity above the highest bin edge is not included in the binning. Using the standard metallicities, this results in some very high SF not being included in the metallicity distribution. SF below the lowest metallicity bin is included in the lowest bin.
This can be fixed by:
Adding 1 additional point to the interp1d input: $Z=1$ (in absolute metallicity units) with CDF=1, since this is per definition the maximum possible metallicity fraction. The fixed the values above 1 from the extrapolation and now only requires interpolation.
The fraction of SF above the maximum bin is added to the highest metallicity bin considered. Similar to how this is done for the lowest bin.
Commit b06739c shows the fix for the new analysis framework. I won't be back propagating this to the development branch for now, since hopefully the max_synpop_population branch will be merged soon.
The text was updated successfully, but these errors were encountered:
The distribution metallicity from the TNG simulation has incorrect weights at the high metallicity end, because of 2 reasons:
interp1d
to extrapolate the cumulative density function. This results in CDF values above 1 due to the extrapolation. This should not happen.This can be fixed by:
interp1d
input:Commit b06739c shows the fix for the new analysis framework. I won't be back propagating this to the development branch for now, since hopefully the
max_synpop_population
branch will be merged soon.The text was updated successfully, but these errors were encountered: