You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the default population_params.inispin_orbit_tilt is one of the default output options.
However with PR #129, this attribute has been removed from the SingleStar and been replaced with: spin_orbit_tilt_first_SN and spin_orbit_tilt_second_SN
The default should be changed or spin_orbit_tilt option should output both.
What is the preferred behaviour here?
The text was updated successfully, but these errors were encountered:
if not hasattr(self, 'spin_orbit_tilt_first_SN'):
self.spin_orbit_tilt_SN1 = None
if not hasattr(self, 'spin_orbit_tilt_second_SN'):
self.spin_orbit_tilt_SN2 = None
We use S1, S2, CC1, CC2 etc so it is inconsistent to use first_SN and second_SN. If we can reduce that, especially in the output, that would be best I think.
In the default
population_params.ini
spin_orbit_tilt
is one of the default output options.However with PR #129, this attribute has been removed from the SingleStar and been replaced with:
spin_orbit_tilt_first_SN
andspin_orbit_tilt_second_SN
The default should be changed or
spin_orbit_tilt
option should output both.What is the preferred behaviour here?
The text was updated successfully, but these errors were encountered: